decrease buckets number, handle getMore case

Author: neSpecc

docs/METRICS.md

@@ -55,7 +55,7 @@ Duration of HTTP requests in seconds, labeled by:
 - `route` - Request route/path
 - `status_code` - HTTP status code
 
-Buckets: 0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5, 10 seconds
+Buckets: 0.01, 0.05, 0.1, 0.5, 1, 5, 10 seconds
 
 #### http_requests_total (Counter)
 
@@ -74,7 +74,7 @@ Labels:
 - `operation_name` - Name of the GraphQL operation
 - `operation_type` - Type of operation (query, mutation, subscription)
 
-Buckets: 0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5, 10 seconds
+Buckets: 0.01, 0.05, 0.1, 0.5, 1, 5, 10 seconds
 
 **Purpose**: Identify slow API operations (P95/P99 latency).
 
@@ -97,25 +97,34 @@ Labels:
 - `field_name` - Field name being resolved
 - `operation_name` - Name of the GraphQL operation
 
-Buckets: 0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5 seconds
+Buckets: 0.01, 0.05, 0.1, 0.5, 1, 5 seconds
 
 **Purpose**: Find slow or CPU-intensive resolvers that degrade overall performance.
 
 ### MongoDB Metrics
 
 #### hawk_mongo_command_duration_seconds (Histogram)
 
-Histogram of MongoDB command duration by command, collection, and database.
+Histogram of MongoDB command duration by command, collection family, and database.
 
 Labels:
 - `command` - MongoDB command name (find, insert, update, etc.)
-- `collection` - Collection name
+- `collection_family` - Collection family name (extracted from dynamic collection names to reduce cardinality)
 - `db` - Database name
 
-Buckets: 0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5, 10 seconds
+Buckets: 0.01, 0.05, 0.1, 0.5, 1, 5, 10 seconds
 
 **Purpose**: Detect slow queries and high-latency collections.
 
+**Note on Collection Families**: To reduce metric cardinality, dynamic collection names are grouped into families. For example:
+- `events:projectId` → `events`
+- `dailyEvents:projectId` → `dailyEvents`
+- `repetitions:projectId` → `repetitions`
+- `membership:userId` → `membership`
+- `team:workspaceId` → `team`
+
+This prevents metric explosion when dealing with thousands of projects, users, or workspaces, while still providing meaningful insights into collection performance patterns.
+
 #### hawk_mongo_command_errors_total (Counter)
 
 Counter of failed MongoDB commands grouped by command and error code.
@@ -173,6 +182,7 @@ The metrics implementation uses the `prom-client` library and consists of:
    - Implements MongoDB command monitoring
    - Tracks command duration and errors
    - Uses MongoDB's command monitoring events
+   - Extracts collection families from dynamic collection names to reduce cardinality
 
 4. **Integration** (`src/index.ts`, `src/mongo.ts`):
    - Adds GraphQL metrics plugin to Apollo Server

src/metrics/graphql.ts

@@ -10,7 +10,7 @@ export const gqlOperationDuration = new client.Histogram({
   name: 'hawk_gql_operation_duration_seconds',
   help: 'Histogram of total GraphQL operation duration by operation name and type',
   labelNames: ['operation_name', 'operation_type'],
-  buckets: [0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5, 10],
+  buckets: [0.01, 0.05, 0.1, 0.5, 1, 5, 10],
 });
 
 /**
@@ -31,7 +31,7 @@ export const gqlResolverDuration = new client.Histogram({
   name: 'hawk_gql_resolver_duration_seconds',
   help: 'Histogram of resolver execution time per type, field, and operation',
   labelNames: ['type_name', 'field_name', 'operation_name'],
-  buckets: [0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5],
+  buckets: [0.01, 0.05, 0.1, 0.5, 1, 5],
 });
 
 /**

src/metrics/index.ts

@@ -21,7 +21,7 @@ const httpRequestDuration = new client.Histogram({
   name: 'http_request_duration_seconds',
   help: 'Duration of HTTP requests in seconds',
   labelNames: ['method', 'route', 'status_code'],
-  buckets: [0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5, 10],
+  buckets: [0.01, 0.05, 0.1, 0.5, 1, 5, 10],
   registers: [ register ],
 });
 

src/metrics/mongodb.ts

@@ -9,7 +9,7 @@ export const mongoCommandDuration = new promClient.Histogram({
   name: 'hawk_mongo_command_duration_seconds',
   help: 'Histogram of MongoDB command duration by command, collection family, and db',
   labelNames: ['command', 'collection_family', 'db'],
-  buckets: [0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5, 10],
+  buckets: [0.01, 0.05, 0.1, 0.5, 1, 5, 10],
 });
 
 /**
@@ -22,6 +22,64 @@ export const mongoCommandErrors = new promClient.Counter({
   labelNames: ['command', 'error_code'],
 });
 
+/**
+ * Extract collection name from MongoDB command
+ * Handles different command types and their collection name locations
+ * @param command - MongoDB command object
+ * @param commandName - Name of the command (find, insert, getMore, etc.)
+ * @returns Raw collection identifier or null
+ */
+function extractCollectionFromCommand(command: any, commandName: string): unknown {
+  if (!command) {
+    return null;
+  }
+
+  // Special handling for getMore command - collection is in a different field
+  if (commandName === 'getMore') {
+    return command.collection || null;
+  }
+
+  /*
+   * For most commands, collection name is the value of the command name key
+   * e.g., { find: "users" } -> collection is "users"
+   */
+  return command[commandName] || null;
+}
+
+/**
+ * Normalize collection value to string
+ * Handles BSON types and other non-string values
+ * @param collection - Collection value from MongoDB command
+ * @returns Normalized string or 'unknown'
+ */
+function normalizeCollectionName(collection: unknown): string {
+  if (!collection) {
+    return 'unknown';
+  }
+
+  // Handle string values directly
+  if (typeof collection === 'string') {
+    return collection;
+  }
+
+  // Handle BSON types and objects with toString method
+  if (typeof collection === 'object' && 'toString' in collection) {
+    try {
+      const str = String(collection);
+
+      // Skip if toString returns object representation like [object Object]
+      if (!str.startsWith('[object') && str !== 'unknown') {
+        return str;
+      }
+    } catch (e) {
+      console.error('Error normalizing collection name', e);
+      // Ignore conversion errors
+    }
+  }
+
+  return 'unknown';
+}
+
 /**
  * Extract collection family from full collection name
  * Reduces cardinality by grouping dynamic collections
@@ -65,8 +123,10 @@ export function setupMongoMetrics(client: MongoClient): void {
     const metadataKey = `${event.requestId}`;
 
     // Extract collection name from the command
-    const collection = event.command ? ((event.command)[event.commandName] || 'unknown') : 'unknown';
+    const collectionRaw = extractCollectionFromCommand(event.command, event.commandName);
+    const collection = normalizeCollectionName(collectionRaw);
     const collectionFamily = getCollectionFamily(collection);
+
     const db = event.databaseName || 'unknown';
 
     // eslint-disable-next-line @typescript-eslint/no-explicit-any