fix(api): correct dailyEvents $limit gating

Author: Kuchizu

src/dataLoaders.ts

@@ -68,36 +68,27 @@ export default class DataLoaders {
    * Batching function for resolving entities from their ids
    * @param collectionName - collection name to get entities
    * @param ids - ids for resolving
-   * @param projection - optional mongo projection to limit returned fields
    */
   private async batchByIds<T extends { _id: ObjectId }>(
     collectionName: string,
-    ids: ReadonlyArray<string>,
-    projection?: Record<string, 0 | 1>
+    ids: ReadonlyArray<string>
   ): Promise<(WithId<T> | null)[]> {
-    return this.batchByField<T, '_id'>(
-      collectionName,
-      '_id',
-      ids.map(id => new ObjectId(id)),
-      projection
-    );
+    return this.batchByField<T, '_id'>(collectionName, '_id', ids.map(id => new ObjectId(id)));
   }
 
   /**
    * Batching function for resolving entities by certain field
    * @param collectionName - collection name to get entities
    * @param fieldName - field name to resolve
    * @param values - values for resolving
-   * @param projection - optional mongo projection to limit returned fields
    */
   private async batchByField<
     T extends Record<string, any>,
     FieldType extends keyof T
   >(
     collectionName: string,
     fieldName: FieldType,
-    values: ReadonlyArray<T[FieldType]>,
-    projection?: Record<string, 0 | 1>
+    values: ReadonlyArray<T[FieldType]>
   ): Promise<(WithId<T> | null)[]> {
     type Doc = WithId<T>;
     const valuesMap = new Map<string, FieldType>();
@@ -108,10 +99,9 @@ export default class DataLoaders {
 
     const queryResult = await this.dbConnection
       .collection<T>(collectionName)
-      .find(
-        { [fieldName]: { $in: Array.from(valuesMap.values()) } } as any,
-        projection ? { projection } : {}
-      )
+      .find({
+        [fieldName]: { $in: Array.from(valuesMap.values()) },
+      } as any)
       .toArray();
 
     /**

src/models/eventsFactory.js

@@ -403,9 +403,14 @@ class EventsFactory extends Factory {
       return { 'event.assignee': String(assignee) };
     })();
 
-    /** When false, $limit can move before the $lookups. */
+    /**
+     * These filters match joined event.* fields, so their $match must run
+     * after the lookups. With none set, $limit can move before the lookups
+     * and skip joining rows we'd drop anyway (~8.8s).
+     * Trim search to match searchFilter's own condition.
+     */
     const hasContentFilters =
-      escapedSearch.length > 0 ||
+      search.trim().length > 0 ||
       Boolean(release) ||
       Boolean(assignee) ||
       Object.keys(matchFilter).length > 0;