feat(core): add releasesFactory to set releases list#475
Merged
3388ShubinPavel merged 30 commits intomasterfrom Mar 26, 2025
Merged
feat(core): add releasesFactory to set releases list#4753388ShubinPavel merged 30 commits intomasterfrom
3388ShubinPavel merged 30 commits intomasterfrom
Conversation
neSpecc
requested changes
Mar 15, 2025
e11sy
reviewed
Mar 15, 2025
rm logs rm commit type add eng lang
….nodejs into feat-release
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 54.62% 54.54% -0.08%
==========================================
Files 9 9
Lines 119 121 +2
Branches 10 10
==========================================
+ Hits 65 66 +1
- Misses 50 51 +1
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
neSpecc
reviewed
Mar 16, 2025
neSpecc
approved these changes
Mar 19, 2025
e11sy
reviewed
Mar 19, 2025
src/dataLoaders.ts
Outdated
| import DataLoader from 'dataloader'; | ||
| import { Db, ObjectId } from 'mongodb'; | ||
| import { PlanDBScheme, UserDBScheme, WorkspaceDBScheme, ProjectDBScheme } from '@hawk.so/types'; | ||
| import { PlanDBScheme, UserDBScheme, WorkspaceDBScheme, ProjectDBScheme, ReleaseDBScheme } from '@hawk.so/types'; |
src/models/releaseFactory.ts
Outdated
Comment on lines
+67
to
+79
| return releases.map(release => ({ | ||
| ...release, | ||
| files: release.files?.map(file => { | ||
| const fileDetail = release.fileDetails?.find( | ||
| (detail: SourceMapFileChunk) => detail._id.toString() === file._id?.toString() | ||
| ); | ||
|
|
||
| return { | ||
| ...file, | ||
| size: fileDetail ? fileDetail.length : 0, | ||
| }; | ||
| }), | ||
| })); |
Contributor
There was a problem hiding this comment.
this triple nesting seems wrong to me, can we optimize it somehow?
- rm redunant import - optimize triple nesting
e11sy
reviewed
Mar 26, 2025
| """ | ||
| Project releases | ||
| """ | ||
| releases: [Release!]! |
Contributor
There was a problem hiding this comment.
why releases list is required in project, what if user never sent any releases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.