Fix Docker build failure after Morgan logger was added#537
Merged
Conversation
Co-authored-by: neSpecc <3684889+neSpecc@users.noreply.github.com>
neSpecc
reviewed
Oct 8, 2025
Copilot
AI
changed the title
[WIP] Fix build failure caused by missing Morgan type declarations
Fix Docker build failure after Morgan logger was added
Oct 8, 2025
…hanges Co-authored-by: neSpecc <3684889+neSpecc@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
neSpecc
approved these changes
Oct 8, 2025
neSpecc
added a commit
that referenced
this pull request
Oct 8, 2025
* chore: Update license to BUSL-1.1 in package.json and add license section in README.md * Bump version up to 1.1.39 * chore: Bump version to 1.1.39 in package.json * chore(devops): add Morgan request logger middleware for HTTP logging (#535) * Initial plan * Add morgan request logger middleware Co-authored-by: neSpecc <3684889+neSpecc@users.noreply.github.com> * Bump version up to 1.1.40 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: neSpecc <3684889+neSpecc@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fix Docker build failure after Morgan logger was added (#537) * Initial plan * Fix Docker build by installing devDependencies in builder stage Co-authored-by: neSpecc <3684889+neSpecc@users.noreply.github.com> * Bump version up to 1.1.41 * Move @types/morgan to production dependencies instead of Dockerfile changes Co-authored-by: neSpecc <3684889+neSpecc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: neSpecc <3684889+neSpecc@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Dobrunia Kostrigin <48620984+Dobrunia@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: neSpecc <3684889+neSpecc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After merging #535 which added the Morgan request logger middleware, the Docker build started failing with the following TypeScript error:
See the failed build: https://github.com/codex-team/hawk.api.nodejs/actions/runs/18351556975/job/52272616011?pr=533
Root Cause
The issue was in
docker/Dockerfile.prod. The builder stage was usingyarn install --prodwhich only installs production dependencies. However, the subsequentyarn buildcommand requires TypeScript type definitions including@types/morgan.Solution
Moved
@types/morganfrom devDependencies to dependencies (production dependencies) inpackage.json.This follows the existing pattern in the project where other
@types/*packages are already in production dependencies (e.g.,@types/mongodb,@types/node,@types/jsonwebtoken, etc.).With
@types/morgannow in production dependencies, it will be available whenyarn install --prodruns in the Docker builder stage, allowing the TypeScript compiler to find the type declarations.This approach:
Verification
yarn buildruns successfullyyarn lint-testpasses with no new errorsFixes the build failure reported in #535.
Fixes #536
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.