Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes chart data processing by reducing CPU usage and database bottlenecks when handling large datasets (~380k records). The changes eliminate unnecessary memory allocation and reduce database payload size.
- Replaced
.toArray()with cursor-based streaming processing to avoid loading all records into memory - Added MongoDB projection to fetch only required fields (
lastRepetitionTime,groupingTimestamp,count) - Implemented direct aggregation during iteration instead of multiple passes over the data
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/models/eventsFactory.js | Optimized chart data processing with cursor streaming and direct aggregation |
| package.json | Version bump from 1.2.0 to 1.2.1 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
neSpecc
approved these changes
Oct 10, 2025
…m/hawk.api.nodejs into imp-chart-data-request
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
slaveeks
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPU usage reduced:
.toArray()the whole db call resultDb bottleneck solution: