Feat(project-settings): add manual Events Grouping page in project settings #677
Merged
Feat(project-settings): add manual Events Grouping page in project settings #677
Conversation
- add pattern - update pattern - remove pattern
neSpecc
reviewed
Mar 16, 2025
| ...ProjectNotificationsRule | ||
| } | ||
| eventGroupingPatterns { | ||
| ...EventGroupingPattern |
Member
There was a problem hiding this comment.
Suggested change
| ...EventGroupingPattern | |
| id | |
| pattern |
| * @returns {Promise<ProjectEventGroupingPattern>} - created pattern | ||
| */ | ||
| export async function addEventGroupingPattern(payload) { | ||
| const response = (await api.callOld(MUTATION_CREATE_PROJECT_PATTERN, { |
Member
There was a problem hiding this comment.
use .call() instead of deprecated .callOld()
|
|
||
| // language=GraphQL | ||
| export const MUTATION_CREATE_PROJECT_PATTERN = ` | ||
| mutation ( $input: CreateProjectEventGroupingPatternInput! ){ |
neSpecc
reviewed
Mar 16, 2025
| <input | ||
| v-model="createPatternForm" | ||
| class="input section__input" | ||
| :placeholder="$t('projects.settings.patterns.createPattern.placeholder')" |
Member
There was a problem hiding this comment.
you can hardcore placeholder, it should not be translated since it it the error title example
| /** | ||
| * If new pattern is empty, then we should remove it | ||
| */ | ||
| if (pattern.pattern === '') { |
Member
There was a problem hiding this comment.
Suggested change
| if (pattern.pattern === '') { | |
| if (pattern.pattern.trim() === '') { |
neSpecc
approved these changes
Mar 16, 2025
neSpecc
approved these changes
Mar 18, 2025
neSpecc
reviewed
Mar 19, 2025
neSpecc
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Note
this is part of global work on Event Manual Grouping feature, check related prs
API: codex-team/hawk.api.nodejs#478
GROUPER: codex-team/hawk.workers#382
TYPES: codex-team/hawk.types#46- already merged