Skip to content

Commit 51fa5ca

Browse files
committed
Fix task manager env parsing and event timestamp filter
Replaces Number() with parseInt() for MAX_AUTO_TASKS_PER_DAY to ensure correct parsing. Fixes event query to filter by timestamp using connectedAt, and enables the super.start() call. Also corrects a typo in a comment in GrouperWorker.
1 parent 67fd150 commit 51fa5ca

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

workers/grouper/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ export default class GrouperWorker extends Worker {
134134
existedEvent = similarEvent;
135135
} else {
136136
/**
137-
* If we couldn't group by grouping pattern — try grouping bt hash (title)
137+
* If we couldn't group by grouping pattern — try grouping by hash (title)
138138
*/
139139
/**
140140
* Find event by group hash.

workers/task-manager/src/index.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import HawkCatcher from '@hawk.so/nodejs';
1414
import { decodeUnsafeFields } from '../../../lib/utils/unsafeFields';
1515
import { GitHubService } from './GithubService';
1616
import { formatIssueFromEvent } from './utils/issue';
17+
import TimeMs from '../../../lib/utils/time';
1718

1819
/**
1920
* Default maximum number of auto-created tasks per project per day
@@ -23,7 +24,7 @@ const DEFAULT_MAX_AUTO_TASKS_PER_DAY = 10;
2324
/**
2425
* Maximum number of auto-created tasks per project per day
2526
*/
26-
const MAX_AUTO_TASKS_PER_DAY = Number(process.env.MAX_AUTO_TASKS_PER_DAY) || DEFAULT_MAX_AUTO_TASKS_PER_DAY;
27+
const MAX_AUTO_TASKS_PER_DAY = parseInt(process.env.MAX_AUTO_TASKS_PER_DAY, 10) || DEFAULT_MAX_AUTO_TASKS_PER_DAY;
2728

2829
/**
2930
* Worker for automatically creating GitHub issues for errors that meet the threshold
@@ -56,7 +57,7 @@ export default class TaskManagerWorker extends Worker {
5657
await this.accountsDb.connect();
5758
await this.eventsDb.connect();
5859

59-
// await super.start();
60+
await super.start();
6061
this.handle({ type: 'auto-task-creation' });
6162
}
6263

@@ -612,10 +613,16 @@ export default class TaskManagerWorker extends Worker {
612613
const connection = await this.eventsDb.getConnection();
613614
const eventsCollection = connection.collection<GroupedEventDBScheme>(`events:${projectId}`);
614615

616+
/**
617+
* Convert connectedAt to timestamp (seconds)
618+
*/
619+
const connectedAtTimestamp = Math.floor(connectedAt.getTime() / TimeMs.SECOND);
620+
621+
615622
const events = await eventsCollection
616623
.find({
617624
taskManagerItem: { $exists: false },
618-
// timestamp: { $gte: connectedAtTimestamp },
625+
timestamp: { $gte: connectedAtTimestamp },
619626
totalCount: { $gte: threshold },
620627
})
621628
.sort({

0 commit comments

Comments
 (0)