Skip to content

Commit a583997

Browse files
committed
chore(): change metric type
1 parent f9b181d commit a583997

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

workers/grouper/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ export default class GrouperWorker extends Worker {
270270
}
271271
}
272272

273-
await this.recordProjectMetrics(task.projectId, 'events-stored');
273+
await this.recordProjectMetrics(task.projectId, 'events-accepted');
274274
}
275275

276276
/**

workers/grouper/tests/index.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,7 @@ describe('GrouperWorker', () => {
743743
});
744744
});
745745

746-
describe('Events-stored metrics', () => {
746+
describe('Events-accepted metrics', () => {
747747
test('writes minutely, hourly, and daily samples after handling an event', async () => {
748748
const safeTsAddSpy = jest.spyOn((worker as any).redis, 'safeTsAdd');
749749

@@ -754,27 +754,27 @@ describe('GrouperWorker', () => {
754754

755755
const expectedLabels = {
756756
type: 'error',
757-
status: 'events-stored',
757+
status: 'events-accepted',
758758
project: projectIdMock,
759759
};
760760

761761
expect(safeTsAddSpy).toHaveBeenNthCalledWith(
762762
1,
763-
`ts:project-events-stored:${projectIdMock}:minutely`,
763+
`ts:project-events-accepted:${projectIdMock}:minutely`,
764764
1,
765765
expectedLabels,
766766
TimeMs.DAY
767767
);
768768
expect(safeTsAddSpy).toHaveBeenNthCalledWith(
769769
2,
770-
`ts:project-events-stored:${projectIdMock}:hourly`,
770+
`ts:project-events-accepted:${projectIdMock}:hourly`,
771771
1,
772772
expectedLabels,
773773
TimeMs.WEEK
774774
);
775775
expect(safeTsAddSpy).toHaveBeenNthCalledWith(
776776
3,
777-
`ts:project-events-stored:${projectIdMock}:daily`,
777+
`ts:project-events-accepted:${projectIdMock}:daily`,
778778
1,
779779
expectedLabels,
780780
90 * TimeMs.DAY
@@ -799,7 +799,7 @@ describe('GrouperWorker', () => {
799799
try {
800800
await worker.handle(generateTask());
801801

802-
expect(loggerErrorSpy).toHaveBeenCalledWith('Failed to add hourly TS for events-stored', failure);
802+
expect(loggerErrorSpy).toHaveBeenCalledWith('Failed to add hourly TS for events-accepted', failure);
803803
expect(await eventsCollection.find().count()).toBe(1);
804804
} finally {
805805
safeTsAddSpy.mockRestore();
@@ -814,7 +814,7 @@ describe('GrouperWorker', () => {
814814
await worker.handle(generateTask());
815815

816816
expect(recordMetricsSpy).toHaveBeenCalledTimes(1);
817-
expect(recordMetricsSpy).toHaveBeenCalledWith(projectIdMock, 'events-stored');
817+
expect(recordMetricsSpy).toHaveBeenCalledWith(projectIdMock, 'events-accepted');
818818
} finally {
819819
recordMetricsSpy.mockRestore();
820820
}

0 commit comments

Comments
 (0)