Skip to content

Commit d289f51

Browse files
committed
chore(): get rid of EventDataAccepted
1 parent 986cd37 commit d289f51

3 files changed

Lines changed: 18 additions & 9 deletions

File tree

workers/grouper/tests/mocks/generateEvent.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { EventAddons, EventData } from '@hawk.so/types';
1+
import type { DefaultAddons, EventAddons, EventData, JavaScriptAddons } from '@hawk.so/types';
22
import { generateRandomId } from './randomId';
33

44
/**
@@ -11,7 +11,7 @@ const userIdMock = generateRandomId();
1111
*
1212
* @param event - Partial event data to override default values
1313
*/
14-
export function generateEvent(event: Partial<EventData<EventAddons>> = undefined): EventData<EventAddons> {
14+
export function generateEvent(event: Partial<EventData<JavaScriptAddons>> = undefined): EventData<JavaScriptAddons> {
1515
return {
1616
title: 'Hawk client catcher test',
1717
backtrace: [],
@@ -23,11 +23,19 @@ export function generateEvent(event: Partial<EventData<EventAddons>> = undefined
2323
'ima$ge.jpg': 'img',
2424
},
2525
addons: {
26+
window: {
27+
innerWidth: 1024,
28+
innerHeight: 768,
29+
},
30+
userAgent: 'Hawk client catcher test',
31+
url: 'https://hawk.so',
2632
vue: {
2733
props: {
2834
'test-test': false,
2935
'ima$ge.jpg': 'img',
3036
},
37+
lifecycle: 'Mounted',
38+
component: 'TestComponent',
3139
},
3240
},
3341
...event,
Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import type { EventAddons, EventDataAccepted } from '@hawk.so/types';
1+
import type { ErrorsCatcherType, EventData, JavaScriptAddons } from '@hawk.so/types';
22
import type { GroupWorkerTask } from '../../types/group-worker-task';
33
import { projectIdMock } from './projectId';
44
import { generateEvent } from './generateEvent';
@@ -9,11 +9,12 @@ import { generateEvent } from './generateEvent';
99
* @param event - allows to override some event properties in generated task
1010
*/
1111
export function generateTask(
12-
event: Partial<EventDataAccepted<EventAddons>> = undefined
13-
): GroupWorkerTask {
12+
event: Partial<EventData<JavaScriptAddons>> = undefined
13+
): GroupWorkerTask<ErrorsCatcherType> {
1414
return {
1515
projectId: projectIdMock,
16-
catcherType: 'grouper',
17-
event: generateEvent(event),
16+
catcherType: 'errors/javascript',
17+
payload: generateEvent(event),
18+
timestamp: new Date().getTime(),
1819
};
1920
}

workers/notifier/types/notifier-task.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import { EventDataAccepted, EventAddons } from '@hawk.so/types';
1+
import { EventAddons, EventData } from '@hawk.so/types';
22
import { WorkerTask } from '../../../lib/types/worker-task';
33

44
/**
55
* Data needed for NotificationWorker from GrouperWorker
66
*/
7-
export type NotifierEvent = Pick<EventDataAccepted<EventAddons>, 'title'> & {
7+
export type NotifierEvent = Pick<EventData<EventAddons>, 'title'> & {
88
/**
99
* Event group hash
1010
*/

0 commit comments

Comments
 (0)