feat(webhook): add assignee information to webhook payload and update related tests

Author: Dobrunia

workers/sender/src/index.ts

@@ -253,6 +253,7 @@ export default abstract class SenderWorker extends Worker {
         project,
         event,
         whoAssigned,
+        assignee,
         daysRepeated,
       },
     } as AssigneeNotification);

workers/sender/types/template-variables/assignee.ts

@@ -21,6 +21,11 @@ export interface AssigneeTemplateVariables extends CommonTemplateVariables {
    */
   whoAssigned: UserDBScheme;
 
+  /**
+   * User who was assigned to resolve the event
+   */
+  assignee: UserDBScheme;
+
   /**
    * Number of event repetitions
    */

workers/webhook/src/deliverer.ts

@@ -47,8 +47,23 @@ export default class WebhookDeliverer {
    * @param delivery - webhook delivery { type, payload }
    */
   public async deliver(endpoint: string, delivery: WebhookDelivery): Promise<void> {
+    let url: URL;
+
+    try {
+      url = new URL(endpoint);
+    } catch {
+      this.logger.log('error', `Webhook delivery skipped — invalid URL: ${endpoint}`);
+
+      return;
+    }
+
+    if (url.protocol !== 'https:' && url.protocol !== 'http:') {
+      this.logger.log('error', `Webhook delivery skipped — unsupported protocol: ${url.protocol}`);
+
+      return;
+    }
+
     const body = JSON.stringify(delivery);
-    const url = new URL(endpoint);
     const transport = url.protocol === 'https:' ? https : http;
 
     return new Promise<void>((resolve) => {

workers/webhook/src/templates/generic.ts

@@ -120,7 +120,8 @@ const projectors: Record<string, PayloadProjector> = {
   'assignee': (p) => ({
     project: p.project ? projectDTO(p.project as ProjectDBScheme) : null,
     event: p.event ? eventDTO(p.event as DecodedGroupedEvent) : null,
-    whoAssigned: p.whoAssigned ? userDTO(p.whoAssigned as UserDBScheme) : null,
+    assignedBy: p.whoAssigned ? userDTO(p.whoAssigned as UserDBScheme) : null,
+    assignee: p.assignee ? userDTO(p.assignee as UserDBScheme) : null,
     daysRepeated: p.daysRepeated ?? null,
   }),
 

workers/webhook/tests/__mocks__/assignee-notify.ts

@@ -28,6 +28,10 @@ export default {
       name: 'John Doe',
       email: 'john@example.com',
     },
+    assignee: {
+      name: 'Jane Smith',
+      email: 'jane@example.com',
+    },
     daysRepeated: 3,
   },
 } as AssigneeNotification;

workers/webhook/tests/provider.test.ts

@@ -283,16 +283,20 @@ describe('WebhookProvider', () => {
       });
     });
 
-    it('should include whoAssigned DTO for "assignee"', async () => {
+    it('should include assignedBy, assignee and event DTOs for "assignee"', async () => {
       const provider = new WebhookProvider();
 
       await provider.send(webhookEndpointSample, AssigneeNotifyMock);
 
       const payload = getDeliveredPayload();
-      const who = payload.whoAssigned as Record<string, unknown>;
-
-      expect(who).toHaveProperty('name', 'John Doe');
-      expect(who).toHaveProperty('email', 'john@example.com');
+      const assignedBy = payload.assignedBy as Record<string, unknown>;
+      const assignee = payload.assignee as Record<string, unknown>;
+
+      expect(assignedBy).toHaveProperty('name', 'John Doe');
+      expect(assignedBy).toHaveProperty('email', 'john@example.com');
+      expect(assignee).toHaveProperty('name', 'Jane Smith');
+      expect(assignee).toHaveProperty('email', 'jane@example.com');
+      expect(payload).toHaveProperty('event');
       expect(payload).toHaveProperty('daysRepeated', 3);
     });