Skip to content

fix(paymaster): check subscription before sending email #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TatianaFomina merged 2 commits into from
Mar 18, 2025
Merged

fix(paymaster): check subscription before sending email #386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5377863
Update index.ts
TatianaFomina Mar 17, 2025
1097a1c
Update index.ts
TatianaFomina Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions workers/paymaster/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
* Pay day is calculated by formula: last charge date + 30 days
*
* @param date - last charge date
* @param isDebug

Check warning on line 66 in workers/paymaster/src/index.ts

View workflow job for this annotation

GitHub Actions / ESlint 

Missing JSDoc @param "isDebug" description
*/
private static isTimeToPay(date: Date, isDebug = false): boolean {
const expectedPayDay = new Date(date);
Expand All @@ -85,7 +85,7 @@
* Pay day is calculated by formula: last charge date + 30 days
*
* @param date - last charge date
* @param isDebug

Check warning on line 88 in workers/paymaster/src/index.ts

View workflow job for this annotation

GitHub Actions / ESlint 

Missing JSDoc @param "isDebug" description
*/
private static daysBeforePayday(date: Date, isDebug = false): number {
const expectedPayDay = new Date(date);
Expand Down Expand Up @@ -235,10 +235,8 @@
if (!isTimeToPay) {
/**
* If payday is coming for the paid plans then notify admins
*
* @todo do not notify if card is linked?
*/
if (DAYS_LEFT_ALERT.includes(daysLeft) && !isFreePlan) {
if (DAYS_LEFT_ALERT.includes(daysLeft) && !isFreePlan && !workspace.subscriptionId) {
/**
* Add task for Sender worker
*/
Expand Down
Loading