fix(grouper): identify events similarity only when titles are same#410
Closed
fix(grouper): identify events similarity only when titles are same#410
Conversation
neSpecc
reviewed
May 21, 2025
Comment on lines
+254
to
261
| const similarByTitle = lastUniqueEvents.filter(prevEvent => { | ||
| // const distance = levenshtein(event.title, prevEvent.payload.title); | ||
|
|
||
| return distance < threshold; | ||
| // const threshold = event.title.length * diffTreshold; | ||
|
|
||
| // return distance < threshold; | ||
| return event.title.toLowerCase() === prevEvent.payload.title.toLowerCase(); | ||
| }).pop(); |
Member
There was a problem hiding this comment.
lets just comment out grouping by Levenshtein and implement grouping by title below.
| @@ -249,17 +249,19 @@ export default class GrouperWorker extends Worker { | |||
| const lastUniqueEvents = await this.findLastEvents(projectId, eventsCountToCompare); | |||
Member
There was a problem hiding this comment.
Probably, we can find event by title using mongo. We dont need to get 60 events for that.
| // groupHash: originalEvent.groupHash, | ||
| // }).toArray()).length).toBe(2); | ||
| // }); | ||
|
|
e11sy
approved these changes
May 21, 2025
Member
|
Resolved by #433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.