Skip to content

Fix(grouper): grouping patterns#426

Merged
e11sy merged 2 commits intomasterfrom
fix-grouping-patterns
Jul 17, 2025
Merged

Fix(grouper): grouping patterns#426
e11sy merged 2 commits intomasterfrom
fix-grouping-patterns

Conversation

@e11sy
Copy link
Copy Markdown
Member

@e11sy e11sy commented Jul 17, 2025

Problem

  • grouping patterns are stored in db in format
export interface ProjectEventGroupingPatternsDBScheme {
    /**
     * If of the pattern
     */
    _id: ObjectId;
    /**
     * String that represents regular expression pattern
     */
    pattern: string;
}

but we are treating them as string[]. That leads to this type of errors:

2025-07-17T14:33:40.699Z error: Error while getting original event for pattern [object Object] 
  • also this issue is invisible for tests because of incorrect grouping patterns mocking (they are mocked as string[] as well)

Solution

  • Treat grouping patterns as described in ProjectEventGroupingPatternsDBScheme interface (as they actually stored)
  • Fix mocks in tests

@e11sy e11sy merged commit d752e39 into master Jul 17, 2025
4 checks passed
@e11sy e11sy deleted the fix-grouping-patterns branch July 17, 2025 18:58
e11sy added a commit that referenced this pull request Jul 20, 2025
* chore: update notifier readme (#421)

* chore: update notifier readme

* chore: typo

* chore(notifier): add pic to readme

* chore(notifer): rm redundant

* chore: reorder

* chore: rm redundant

* fix(emails): Update unsubscribe link (#424)

* Update link

* Upd

* Fix tests

* Fix(grouper): grouping patterns (#426)

* fix: grouping patterns

* fix: mocks fixed

---------

Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>
Co-authored-by: Tatiana Fomina <fomina.tatianaaa@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants