Conversation
neSpecc
previously approved these changes
Sep 2, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes source map saving issues by preventing mutation of the original savedFiles object during database transactions. The mutation was causing errors when transactions were retried due to database locks.
- Prevents object mutation in release worker to avoid transaction retry errors
- Refactors file filtering and content removal to use immutable operations
- Uncomments and renames function context extraction functionality in javascript worker
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| workers/release/src/index.ts | Refactors source map saving to avoid mutating original objects and uses immutable operations for filtering and content removal |
| workers/javascript/src/index.ts | Uncomments function context extraction and removes underscore prefix from method name |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const originalContent = consumer.sourceContentFor(originalLocation.source); | ||
|
|
||
| // functionContext = this.getFunctionContext(originalContent, originalLocation.line) ?? originalLocation.name; | ||
| functionContext = this.getFunctionContext(originalContent, originalLocation.line) ?? originalLocation.name; |
There was a problem hiding this comment.
The variable functionContext is being assigned but it's not declared in the visible scope. This will either cause a ReferenceError or create an implicit global variable.
Member
Author
There was a problem hiding this comment.
seems as a strange comment since functionContext is defined just above the condition
neSpecc
approved these changes
Sep 2, 2025
e11sy
added a commit
that referenced
this pull request
Sep 2, 2025
* Js worker fix (#445) * fix(): move logs after the conditions * chore(): fix error sending * fix(): do not use jsx parser * chore(): leave todo * chore(): do not use getFunctionContext * fix(): fix source-map saving (#449) * fix(): avoid mutations on savedFiles * revert js worker changes * fix(): js worker tests * imp(): catch errors on get function context --------- Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>
e11sy
added a commit
that referenced
this pull request
Sep 2, 2025
* Js worker fix (#445) * fix(): move logs after the conditions * chore(): fix error sending * fix(): do not use jsx parser * chore(): leave todo * chore(): do not use getFunctionContext * fix(): fix source-map saving (#449) * fix(): avoid mutations on savedFiles * revert js worker changes * fix(): js worker tests * imp(): catch errors on get function context * chore(): imp perf (#450) --------- Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com>
Dobrunia
added a commit
that referenced
this pull request
Sep 11, 2025
* Js worker fix (#445) * fix(): move logs after the conditions * chore(): fix error sending * fix(): do not use jsx parser * chore(): leave todo * chore(): do not use getFunctionContext * fix(): fix source-map saving (#449) * fix(): avoid mutations on savedFiles * revert js worker changes * fix(): js worker tests * imp(): catch errors on get function context * chore(): imp perf (#450) * fix(hawk-workers-sentry): fix envelope parse error (#448) * fix(sentry): filter out binary items from raw event before parsing to prevent crashes * fix(sentry): enhance binary data handling to prevent crashes during event processing * linf fix * refactor(tests): skip specific test cases for JavaScript event worker --------- Co-authored-by: e11sy <130844513+e11sy@users.noreply.github.com> Co-authored-by: Dobrunia Kostrigin <48620984+Dobrunia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution