-
Notifications
You must be signed in to change notification settings - Fork 1
Trim event title to a maximum length in grouper #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kuchizu
wants to merge
3
commits into
master
Choose a base branch
from
feat/grouper-limit-event-title
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−8
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,7 +59,7 @@ const DB_DUPLICATE_KEY_ERROR = '11000'; | |
| const DAILY_METRICS_RETENTION_DAYS = 90; | ||
|
|
||
| /** | ||
| * Maximum length for backtrace code line or title | ||
| * Maximum length for backtrace code line | ||
| */ | ||
| const MAX_CODE_LINE_LENGTH = 140; | ||
|
|
||
|
|
@@ -198,8 +198,6 @@ export default class GrouperWorker extends Worker { | |
| this.grouperMetrics.observePayloadSize(taskPayloadSize); | ||
| this.memoryMonitor.logBeforeHandle(memoryBeforeHandle, handledTasksCount, taskPayloadSize, task.projectId); | ||
|
|
||
| this.logger.info(`[handle] project=${task.projectId} catcher=${task.catcherType} title="${task.payload.title}" payloadSize=${taskPayloadSize}b backtraceFrames=${task.payload.backtrace?.length ?? 0}`); | ||
|
|
||
| // FIX RELEASE TYPE | ||
| // TODO: REMOVE AFTER 01.01.2026, after the most of the users update to new js catcher | ||
| if (task.payload && task.payload.release !== undefined) { | ||
|
|
@@ -209,6 +207,13 @@ export default class GrouperWorker extends Worker { | |
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Filter event data before logging and hashing so logs, hash and stored event stay consistent. | ||
| */ | ||
| this.dataFilter.processEvent(task.payload); | ||
|
|
||
| this.logger.info(`[handle] project=${task.projectId} catcher=${task.catcherType} title="${task.payload.title}" payloadSize=${taskPayloadSize}b backtraceFrames=${task.payload.backtrace?.length ?? 0}`); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why this log is needed? It will be printed for every event |
||
|
|
||
| let uniqueEventHash = await session.measureStep('hash', () => this.getUniqueEventHash(task)); | ||
| let existedEvent: GroupedEventDBScheme; | ||
| let repetitionId = null; | ||
|
|
@@ -219,11 +224,6 @@ export default class GrouperWorker extends Worker { | |
| * Trim source code lines to prevent memory leaks | ||
| */ | ||
| this.trimSourceCodeLines(task.payload); | ||
|
|
||
| /** | ||
| * Filter sensitive information | ||
| */ | ||
| this.dataFilter.processEvent(task.payload); | ||
| }); | ||
|
|
||
| /** | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we sanitize only title, but long strings (as well as very deep objects, long arrays) can be included in other fields:
I'd suggest to add the Sanitizer utility like we have in Hawk JavaScript. And use it here in DataFilter.