Fix appName option and count billing events via dailyEvents#575
Open
Kuchizu wants to merge 4 commits into
Open
Fix appName option and count billing events via dailyEvents#575Kuchizu wants to merge 4 commits into
Kuchizu wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Mongo connection options for driver 3.x compatibility and refines limiter billing-period event counting by combining raw event scans for the “boundary day” with dailyEvents per-day counters for subsequent days.
Changes:
- Switch Mongo connection option from
appNametoappnamefor MongoDB driver 3.x compatibility. - Update limiter
DbHelper.getEventsCountByProjectto count the partial boundary day via rawevents/repetitionscollections and sum later days viadailyEvents. - Expand limiter DB helper tests to cover dailyEvents-based counting and boundary-day filtering.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| workers/limiter/tests/index.test.ts | Aligns mocked event timestamps with the boundary-day counting model. |
| workers/limiter/tests/dbHelper.test.ts | Adds dailyEvents mocking and new tests for boundary-day vs dailyEvents counting behavior. |
| workers/limiter/src/dbHelper.ts | Implements hybrid counting logic: raw scan for boundary day + aggregated dailyEvents for later days. |
| lib/db/controller.ts | Uses lowercase appname Mongo option key for driver 3.x support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
103
to
+107
| workspace?: WorkspaceDBScheme, | ||
| project: ProjectDBScheme, | ||
| eventsToMock: number | ||
| repetitionsToMock?: number, | ||
| dailyEventsToMock?: Array<{ groupingTimestamp: number; count: number }>, |
neSpecc
reviewed
Jul 8, 2026
Kuchizu
force-pushed
the
perf/mongo-optimizations
branch
from
68f49f6 to
a7dcbb6
Compare
neSpecc
reviewed
Jul 8, 2026
Comment on lines
+350
to
+352
| if (!this.shouldUseDailyEventsCounter(workspace._id.toString())) { | ||
| return this.dbHelper.getEventsCountByProjects(projects, since); | ||
| } |
Member
There was a problem hiding this comment.
Lets compute both counters for such workspaces to be able to compare them.
The most useful way is to send logs to Telegram:
Workspace {name} event count:
Old algo: {old count}, took {time old}sec
New algo: {new count}, took {time new}sec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driver 3.x only accepts lowercase appname
Limiter now sums dailyEvents daily counters for full days and counts raw events/repetitions only for the partial day around lastChargeDate