chore: lint fixes

Author: 7eliassen

eslint.config.mjs

@@ -77,6 +77,9 @@ export default [
       'n/no-unsupported-features/es-builtins': ['error', {
         version: '>=22.1.0',
       }],
+      'n/no-unsupported-features/node-builtins': ['error', {
+        version: '>=22.1.0',
+      }],
       '@typescript-eslint/naming-convention': ['error', {
         selector: 'property',
         format: ['camelCase', 'PascalCase'],

src/infrastructure/logging/index.ts

@@ -46,7 +46,7 @@ export function getRequestLogger(moduleName: keyof LoggingConfig): pino.Logger {
   const baseLogger = getLogger(moduleName);
   const reqId = getCurrentReqId();
 
-  if (reqId) {
+  if (reqId != null && reqId !== '') {
     return baseLogger.child({
       reqId,
     });

src/infrastructure/logging/reqId.context.ts

@@ -19,5 +19,6 @@ export const requestContextStorage = new AsyncLocalStorage<RequestContext>();
  */
 export function getCurrentReqId(): string | undefined {
   const context = requestContextStorage.getStore();
+
   return context?.reqId;
 }

src/presentation/http/middlewares/common/userIdResolver.ts

@@ -7,7 +7,6 @@ import { getRequestLogger } from '@infrastructure/logging/index.js';
  * Add middleware for resolve userId from Access Token and add it to request
  * @param server - fastify instance
  * @param authService - auth domain service
- * @param logger - logger instance
  */
 export default function addUserIdResolver(server: FastifyInstance, authService: AuthService): void {
   /**

src/presentation/http/middlewares/noteSettings/useMemberRoleResolver.ts

@@ -16,7 +16,6 @@ export default function useMemberRoleResolver(noteSettingsService: NoteSettingsS
    */
   memberRoleResolver: preHandlerHookHandler;
 } {
-
   return {
     memberRoleResolver: async function memberRoleResolver(request, reply) {
       const logger = getRequestLogger('middlewares');
@@ -39,7 +38,7 @@ export default function useMemberRoleResolver(noteSettingsService: NoteSettingsS
           request.memberRole = memberRole;
         }
       } catch (error) {
-        if (request.note && request.userId) {
+        if (request.note != null && request.userId != null) {
           logger.error(`Can not resolve Member role by note [id = ${request.note.id}] and user [id = ${request.userId}]`);
         } else {
           logger.error('Can not resolve Member role - note or user ID not available');

src/presentation/http/middlewares/noteSettings/useNoteSettingsResolver.ts

@@ -15,7 +15,6 @@ export default function useNoteSettingsResolver(noteSettingsService: NoteSetting
    */
   noteSettingsResolver: preHandlerHookHandler;
 } {
-
   return {
     noteSettingsResolver: async function noteSettingsResolver(request, reply) {
       const logger = getRequestLogger('middlewares');

src/presentation/http/policies/authRequired.ts

@@ -13,6 +13,7 @@ export default async function authRequired(context: PolicyContext): Promise<void
 
   if (userId === null) {
     logger.warn('User is not authenticated');
+
     return await reply.unauthorized();
   }
 

src/presentation/http/policies/notePublicOrUserInTeam.ts

@@ -18,6 +18,7 @@ export default async function notePublicOrUserInTeam(context: PolicyContext): Pr
    */
   if (isEmpty(request.note) || isEmpty(request.noteSettings)) {
     logger.warn('Note or note settings not found');
+
     return await reply.notAcceptable('Note not found');
   };
 
@@ -40,10 +41,12 @@ export default async function notePublicOrUserInTeam(context: PolicyContext): Pr
     /** If user is unathorized we return 401 unauthorized */
     if (isEmpty(userId)) {
       logger.warn('Unauthorized user trying to access private note');
+
       return await reply.unauthorized();
     /** If user is authorized, but is not in the team, we return 403 forbidden */
     } else if (isEmpty(memberRole)) {
       logger.warn('User not in team for private note');
+
       return await reply.forbidden();
     }
   }

src/presentation/http/policies/userCanEdit.ts

@@ -18,6 +18,7 @@ export default async function userCanEdit(context: PolicyContext): Promise<void>
    */
   if (isEmpty(userId)) {
     logger.warn('User not authenticated for edit access');
+
     return await reply.unauthorized();
   };
 
@@ -26,6 +27,7 @@ export default async function userCanEdit(context: PolicyContext): Promise<void>
    */
   if (isEmpty(request.note)) {
     logger.warn('Note not found for edit permission check');
+
     return await reply.notAcceptable('Note not found');
   };
 
@@ -37,6 +39,7 @@ export default async function userCanEdit(context: PolicyContext): Promise<void>
    */
   if (memberRole !== MemberRole.Write) {
     logger.warn('User does not have write permission for note');
+
     return await reply.forbidden();
   }
 

src/repository/storage/postgres/orm/sequelize/index.ts

@@ -29,6 +29,7 @@ export default class SequelizeOrm {
       benchmark: true,
       logging: (message, timing) => {
         const logger = getRequestLogger('database');
+
         logger.info(
           { durationMs: timing },
           message