Fix: ensure tools are configured before editor renders on note switch#355
Open
7eliassen wants to merge 1 commit into
Open
Fix: ensure tools are configured before editor renders on note switch#3557eliassen wants to merge 1 commit into
7eliassen wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR addresses an intermittent Editor.js rendering issue when switching between notes by ensuring the editor does not render until tool scripts/configuration have been rebuilt for the newly selected note.
Changes:
- Reset
isEditorReadyandtoolsUserConfigLoadedbefore re-loading tool scripts onnoteAndUserToolschanges. - Ensure the editor component remounts only after tools are configured, preventing blocks from rendering with stale/missing tool configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+147
to
150
| isEditorReady.value = false; | ||
| toolsUserConfigLoaded.value = false; | ||
|
|
||
| await loadToolsScripts(tools); |
Comment on lines
+147
to
150
| isEditorReady.value = false; | ||
| toolsUserConfigLoaded.value = false; | ||
|
|
||
| await loadToolsScripts(tools); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Occasionally, when switching between notes, some editor.js blocks may not be displayed correctly.
Root Cause:
toolsUserConfigLoaded and isEditorReady already true when the function is just called
This issue occurs because the toolsUserConfigLoaded and isEditorReady flags are not properly reset. As a result, the editor may render before the tools are fully configured, causing certain blocks to fail to display.
Fix:
Added logic to reset toolsUserConfigLoaded and isEditorReady before calling loadToolsScripts, ensuring that the editor waits for the tools to be properly configured before rendering.