fix warning on DescriptorSet destruction for DescriptorPools not created with a certain flag

Author: codex128

jme3-lwjgl3/src/main/java/com/jme3/vulkan/descriptors/DescriptorPool.java

@@ -4,6 +4,7 @@
 import com.jme3.util.natives.Native;
 import com.jme3.util.natives.NativeReference;
 import com.jme3.vulkan.devices.LogicalDevice;
+import com.jme3.vulkan.util.Flag;
 import org.lwjgl.system.MemoryStack;
 import org.lwjgl.vulkan.*;
 
@@ -14,17 +15,41 @@
 
 public class DescriptorPool implements Native<Long> {
 
+    public enum Create implements Flag<Create> {
+
+        FreeDescriptorSets(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT);
+
+        private final int vkEnum;
+
+        Create(int vkEnum) {
+            this.vkEnum = vkEnum;
+        }
+
+        @Override
+        public int bits() {
+            return vkEnum;
+        }
+
+    }
+
     private final LogicalDevice<?> device;
     private final NativeReference ref;
+    private final Flag<Create> flags;
     private final long id;
 
     public DescriptorPool(LogicalDevice<?> device, int sets, PoolSize... sizes) {
+        this(device, sets, Flag.none(), sizes);
+    }
+
+    public DescriptorPool(LogicalDevice<?> device, int sets, Flag<Create> flags, PoolSize... sizes) {
         this.device = device;
+        this.flags = flags;
         try (MemoryStack stack = MemoryStack.stackPush()) {
             VkDescriptorPoolCreateInfo create = VkDescriptorPoolCreateInfo.calloc(stack)
                     .sType(VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO)
                     .pPoolSizes(PoolSize.aggregate(stack, sizes))
-                    .maxSets(sets);
+                    .maxSets(sets)
+                    .flags(this.flags.bits());
             LongBuffer idBuf = stack.mallocLong(1);
             check(vkCreateDescriptorPool(device.getNativeObject(), create, null, idBuf),
                     "Failed to create descriptor pool.");
@@ -52,6 +77,12 @@ public NativeReference getNativeReference() {
         return ref;
     }
 
+    /**
+     * Allocates a {@link DescriptorSet} for each {@link DescriptorSetLayout} provided.
+     *
+     * @param layouts layouts to allocate DescriptorSets with
+     * @return allocated DescriptorSets, in the same order as {@code layouts}
+     */
     public DescriptorSet[] allocateSets(DescriptorSetLayout... layouts) {
         assert layouts.length > 0 : "Must specify at least one set layout.";
         // layouts length = number of descriptor sets created
@@ -75,4 +106,8 @@ public void reset() {
         vkResetDescriptorPool(device.getNativeObject(), id, 0);
     }
 
+    public boolean isFreeSetsEnabled() {
+        return flags.contains(Create.FreeDescriptorSets);
+    }
+
 }

jme3-lwjgl3/src/main/java/com/jme3/vulkan/descriptors/DescriptorSet.java

@@ -26,7 +26,7 @@ public DescriptorSet(LogicalDevice<?> device, DescriptorPool pool, DescriptorSet
     @Override
     public Runnable createNativeDestroyer() {
         return () -> {
-            try (MemoryStack stack = MemoryStack.stackPush()) {
+            if (pool.isFreeSetsEnabled()) try (MemoryStack stack = MemoryStack.stackPush()) {
                 vkFreeDescriptorSets(device.getNativeObject(), pool.getNativeObject(), stack.longs(object));
             }
         };

jme3-lwjgl3/src/main/java/com/jme3/vulkan/util/Flag.java

@@ -41,6 +41,10 @@ static <T extends Flag> Flag<T> of(int bits) {
         return new FlagImpl<>(bits);
     }
 
+    static <T extends Flag> Flag<T> none() {
+        return of(0);
+    }
+
     @SafeVarargs
     static <T extends Flag> Flag<T> of(Flag<T>... flags) {
         return new FlagImpl<>(flags);