improved scene rendering; improved vulkan tooling; switched vulkan buffers from eager to lazy initialization

Author: codex128

jme3-core/src/main/java/com/jme3/app/BasicProfilerState.java

@@ -166,8 +166,8 @@ protected void refreshBackground() {
             0, 0, 0, 0.5f,
             0, 0, 0, 0.5f
         });
-        pos.unmap();
-        color.unmap();
+        pos.close();
+        color.close();
 
         MappableBuffer indices = mesh.setIndexBufferIfAbsent(() -> getEngine().createBuffer(
                 MemorySize.shorts(6 * 3), BufferUsage.Index, GlVertexBuffer.Usage.Static));
@@ -180,7 +180,7 @@ protected void refreshBackground() {
             8, 10, 11
         });
         indices.unmap();
-        indices.push();
+        indices.stage();
 
     }
 

jme3-core/src/main/java/com/jme3/backend/Engine.java

@@ -1,8 +1,10 @@
+
 package com.jme3.backend;
 
 import com.jme3.material.Material;
 import com.jme3.math.Vector2f;
 import com.jme3.math.Vector3f;
+import com.jme3.renderer.ViewPortArea;
 import com.jme3.scene.GlVertexBuffer;
 import com.jme3.scene.Mesh;
 import com.jme3.texture.Texture;
@@ -11,6 +13,7 @@
 import com.jme3.vulkan.buffers.BufferGenerator;
 import com.jme3.vulkan.buffers.BufferUsage;
 import com.jme3.vulkan.buffers.MappableBuffer;
+import com.jme3.vulkan.commands.RenderSetting;
 import com.jme3.vulkan.material.uniforms.Uniform;
 import com.jme3.vulkan.mesh.InputRate;
 import com.jme3.vulkan.mesh.attribute.Attribute;

jme3-core/src/main/java/com/jme3/backend/OpenGLEngine.java

@@ -14,18 +14,18 @@
 import com.jme3.vulkan.buffers.GlNativeBuffer;
 import com.jme3.vulkan.buffers.MappableBuffer;
 import com.jme3.vulkan.memory.MemorySize;
-import com.jme3.vulkan.render.GeometryBatch;
-import com.jme3.vulkan.render.GlGeometryBatch;
+import com.jme3.vulkan.render.batching.GeometryBatch;
+import com.jme3.vulkan.render.batching.GlGeometryBatch;
 import com.jme3.vulkan.render.RenderEngine;
 import com.jme3.vulkan.util.Flag;
 import com.jme3.vulkan.util.ScenePropertyStack;
-import com.jme3.vulkan.util.SceneStack;
+import com.jme3.vulkan.util.SceneIterationListener;
 
 public class OpenGLEngine implements RenderEngine {
 
     private final GLRenderer renderer = new GLRenderer();
     private GlGeometryBatch opaque, sky, transparent, gui, translucent;
-    private final SceneStack<RenderQueue.Bucket> bucket = new ScenePropertyStack<>(
+    private final SceneIterationListener<RenderQueue.Bucket> bucket = new ScenePropertyStack<>(
             RenderQueue.Bucket.Opaque, RenderQueue.Bucket.Inherit,
             s -> RenderQueue.Bucket.valueOf(s.getLocalQueueBucket()));
 
@@ -36,7 +36,7 @@ public void render(ViewPort vp) {
         transparent.setCamera(vp.getCamera());
         gui.setCamera(new GuiCamera(vp.getCamera(), vp.getViewWidth(), vp.getViewHeight()));
         translucent.setCamera(vp.getCamera());
-        SceneStack<Camera.FrustumIntersect> cull = vp.getCamera().createCullStack();
+        SceneIterationListener<Camera.FrustumIntersect> cull = vp.getCamera().createCullStack();
         for (Spatial scene : vp.getScenes()) for (Spatial.GraphIterator it = scene.iterator(cull, bucket); it.hasNext();) {
             Spatial child = it.next();
             child.runControlRender(this, vp);

jme3-core/src/main/java/com/jme3/backend/SimpleVulkanEngine.java

@@ -43,8 +43,8 @@
 import com.jme3.scene.Mesh;
 import com.jme3.scene.Spatial;
 import com.jme3.util.TempVars;
+import com.jme3.vulkan.mesh.attribute.Attribute;
 import com.jme3.vulkan.mesh.attribute.Position;
-import com.jme3.vulkan.util.FloatBufferModifier;
 
 import java.io.IOException;
 import java.nio.FloatBuffer;
@@ -132,11 +132,34 @@ public Type getType() {
      */
     @Override
     public void computeFromPoints(FloatBuffer points) {
-        containAABB(new FloatBufferModifier(points, 3));
+        if (points.remaining() < 3) {
+            return;
+        }
+        float minX = Float.POSITIVE_INFINITY,
+                minY = Float.POSITIVE_INFINITY,
+                minZ = Float.POSITIVE_INFINITY;
+        float maxX = Float.NEGATIVE_INFINITY,
+                maxY = Float.NEGATIVE_INFINITY,
+                maxZ = Float.NEGATIVE_INFINITY;
+        for (int i = points.position(); i < points.limit(); i += 3) {
+            float x = points.get(i);
+            float y = points.get(i + 1);
+            float z = points.get(i + 2);
+            minX = Math.min(minX, x);
+            minY = Math.min(minY, y);
+            minZ = Math.min(minZ, z);
+            maxX = Math.max(maxX, x);
+            maxY = Math.max(maxY, y);
+            maxZ = Math.max(maxZ, z);
+        }
+        center.set(minX + maxX, minY + maxY, minZ + maxZ).multLocal(0.5f);
+        xExtent = maxX - center.x;
+        yExtent = maxY - center.y;
+        zExtent = maxZ - center.z;
     }
 
     @Override
-    public void computeFromPoints(VertexReader points) {
+    public void computeFromPoints(Attribute<Vector3f> points) {
         containAABB(points);
     }
 
@@ -203,6 +226,7 @@ public void computeFromTris(Triangle[] tris, int start, int end) {
         vars.release();
     }
 
+    @Deprecated
     public void computeFromTris(int[] indices, Mesh mesh, int start, int end) {
         if (end - start <= 0) {
             return;
@@ -219,7 +243,8 @@ public void computeFromTris(int[] indices, Mesh mesh, int start, int end) {
         Vector3f point;
 
         for (int i = start; i < end; i++) {
-            mesh.getTriangle(indices[i], triangle);
+            // build error here
+            //mesh.getTriangle(indices[i], triangle);
             point = triangle.get(0);
             checkMinMax(min, max, point);
             point = triangle.get(1);
@@ -267,17 +292,11 @@ public static void checkMinMax(Vector3f min, Vector3f max, Vector3f point) {
      * @param points
      *            the list of points.
      */
-    public void containAABB(VertexReader points) {
+    public void containAABB(Attribute<Vector3f> points) {
         if (points == null) {
             return;
         }
 
-        //points.rewind();
-        if (points.limit() == 0) // we need at least a 3 float vector
-        {
-            return;
-        }
-
         TempVars vars = TempVars.get();
 
         float minX = Float.POSITIVE_INFINITY,
@@ -287,17 +306,13 @@ public void containAABB(VertexReader points) {
                 maxY = Float.NEGATIVE_INFINITY,
                 maxZ = Float.NEGATIVE_INFINITY;
 
-        for (int i = 0, l = points.limit(); i < l; i++) {
-//                vars.vect1.x = tmpArray[j];
-//                vars.vect1.y = tmpArray[j + 1];
-//                vars.vect1.z = tmpArray[j + 2];
-            points.getVector3(i, 0, vars.vect1);
-            minX = Math.min(minX, vars.vect1.x);
-            minY = Math.min(minY, vars.vect1.y);
-            minZ = Math.min(minZ, vars.vect1.z);
-            maxX = Math.max(maxX, vars.vect1.x);
-            maxY = Math.max(maxY, vars.vect1.y);
-            maxZ = Math.max(maxZ, vars.vect1.z);
+        for (Vector3f p : points.read(vars.vect1)) {
+            minX = Math.min(minX, p.x);
+            minY = Math.min(minY, p.y);
+            minZ = Math.min(minZ, p.z);
+            maxX = Math.max(maxX, p.x);
+            maxY = Math.max(maxY, p.y);
+            maxZ = Math.max(maxZ, p.z);
         }
 
         vars.release();