Refactor StreamUpdates method to be asynchronous

Author: codez0mb1e

src/BinanceBot.Market/MarketDepthManager.cs

@@ -172,22 +172,24 @@ public async Task BuildAsync(MarketDepth marketDepth, short orderBookDepth = 10,
     /// Stream <see cref="MarketDepth"/> updates
     /// </summary>
     /// <param name="marketDepth">Market depth</param>
+    /// Stream <see cref="MarketDepth"/> updates asynchronously.
+    /// </summary>
+    /// <param name="marketDepth">Market depth</param>
     /// <param name="updateInterval">Update interval (100ms or 1000ms)</param>
-    public void StreamUpdates(MarketDepth marketDepth, TimeSpan? updateInterval = default, CancellationToken ct = default)
+    public async Task StreamUpdatesAsync(MarketDepth marketDepth, TimeSpan? updateInterval = default, CancellationToken ct = default)
     {
         if (marketDepth == null)
             throw new ArgumentNullException(nameof(marketDepth));
 
         // Step 1 & 2: Open WebSocket and buffer events
-        _subscription = _webSocketClient.SpotStreams.SubscribeToOrderBookUpdatesAsync(
+        var subscriptionResult = await _webSocketClient.SpotStreams.SubscribeToOrderBookUpdatesAsync(
             marketDepth.Symbol,
             updateInterval.HasValue ? (int)updateInterval.Value.TotalMilliseconds : (int)_defaultUpdateInterval.TotalMilliseconds,
             data => OnDepthUpdate(marketDepth, data),
-            ct)
-            .Result.Data;
-    }
+            ct);
 
-    /// <summary>
+        _subscription = subscriptionResult.Data;
+    }
     /// Stop streaming updates and unsubscribe
     /// </summary>
     public async Task StopStreamingAsync(CancellationToken ct = default)

src/BinanceBot.Market/MarketMakerBot.cs

@@ -140,7 +140,7 @@ public override async Task RunAsync()
         var marketDepthManager = new MarketDepthManager(_binanceRestClient, _webSocketClient, Logger);
         var updateInterval = TimeSpan.FromMilliseconds(1000);
         // stream order book updates
-        marketDepthManager.StreamUpdates(_marketDepth, updateInterval);
+        await marketDepthManager.StreamUpdatesAsync(_marketDepth, updateInterval);
         // build order book
         await marketDepthManager.BuildAsync(_marketDepth, orderBookDepth: 100, updateInterval: updateInterval);
     } 

tests/BinanceBot.Market.Tests/MarketDepthManagerTests.cs

@@ -114,14 +114,14 @@ await Assert.ThrowsAsync<ArgumentOutOfRangeException>(() =>
     }
 
     [Fact]
-    public void StreamUpdates_WithNullMarketDepth_ThrowsArgumentNullException()
+    public async Task StreamUpdates_WithNullMarketDepth_ThrowsArgumentNullException()
     {
         // Arrange
         var manager = new MarketDepthManager(_mockRestClient.Object, _mockSocketClient.Object, _mockLogger.Object);
 
         // Act & Assert
-        Assert.Throws<ArgumentNullException>(() => 
-            manager.StreamUpdates(null));
+        await Assert.ThrowsAsync<ArgumentNullException>(() => 
+            manager.StreamUpdatesAsync(null));
     }
 
     [Fact]