More consistent naming

Author: codez0mb1e

src/BinanceBot.Market/Domain/MarketDepth.cs

@@ -59,14 +59,14 @@ public MarketDepth(MarketSymbol symbol)
     /// <summary>
     /// The best pair. If the order book is empty, will be returned <see langword="null"/>.
     /// </summary>
-    public MarketDepthPair BestPair => LastUpdateTime.HasValue 
-        ? new MarketDepthPair(BestAsk, BestBid, LastUpdateTime.Value) 
+    public MarketDepthPair BestPair => LastUpdateId.HasValue 
+        ? new MarketDepthPair(BestAsk, BestBid, LastUpdateId.Value) 
         : null;
 
     /// <summary>
     /// Last update of market depth
     /// </summary>
-    public long? LastUpdateTime { get; private set; }
+    public long? LastUpdateId { get; private set; }
 
 
 
@@ -77,13 +77,13 @@ public MarketDepth(MarketSymbol symbol)
     /// Update market depth
     /// </summary>
     /// <remarks>
-    public void UpdateDepth(IEnumerable<BinanceOrderBookEntry> asks, IEnumerable<BinanceOrderBookEntry> bids, long updateTime)
+    public void UpdateDepth(IEnumerable<BinanceOrderBookEntry> asks, IEnumerable<BinanceOrderBookEntry> bids, long updateId)
     {
-        if (updateTime <= 0)
-            throw new ArgumentOutOfRangeException(nameof(updateTime));
+        if (updateId <= 0)
+            throw new ArgumentOutOfRangeException(nameof(updateId));
 
         // if nothing was changed then return
-        if (updateTime <= LastUpdateTime) return;
+        if (updateId <= LastUpdateId) return;
         if (asks == null && bids == null) return;
 
 
@@ -111,10 +111,10 @@ static void UpdateOrderBook(IEnumerable<BinanceOrderBookEntry> updates, IDiction
         UpdateOrderBook(asks, _asks);
         UpdateOrderBook(bids, _bids);
         // set new update time
-        LastUpdateTime = updateTime;
+        LastUpdateId = updateId;
 
         // raise events
-        OnMarketDepthChanged(new MarketDepthChangedEventArgs(Asks, Bids, LastUpdateTime.Value));
+        OnMarketDepthChanged(new MarketDepthChangedEventArgs(Asks, Bids, LastUpdateId.Value));
         if(!BestPair.Equals(prevBestPair))
             OnMarketBestPairChanged(new MarketBestPairChangedEventArgs(BestPair));
     }

tests/BinanceBot.Market.Tests/Core/MarketDepthTests.cs

@@ -26,7 +26,7 @@ public void Constructor_WithValidSymbol_CreatesInstance(ContractType contractTyp
         // Assert
         Assert.Equal(symbol, marketDepth.Symbol);
         Assert.Equal(contractType, marketDepth.Symbol.ContractType);
-        Assert.Null(marketDepth.LastUpdateTime);
+        Assert.Null(marketDepth.LastUpdateId);
         Assert.Empty(marketDepth.Asks);
         Assert.Empty(marketDepth.Bids);
     }
@@ -58,7 +58,7 @@ public void UpdateDepth_WithValidData_UpdatesOrderBook()
         marketDepth.UpdateDepth(asks, bids, 123456);
 
         // Assert
-        Assert.Equal(123456, marketDepth.LastUpdateTime);
+        Assert.Equal(123456, marketDepth.LastUpdateId);
         Assert.Equal(2, marketDepth.Asks.Count());
         Assert.Equal(2, marketDepth.Bids.Count());
         Assert.Equal(50000m, marketDepth.BestAsk.Price);
@@ -86,7 +86,7 @@ public void UpdateDepth_WithValidData_UpdatesOrderBook_Perpetual()
 
         // Assert
         Assert.Equal(ContractType.Perpetual, marketDepth.Symbol.ContractType);
-        Assert.Equal(123456, marketDepth.LastUpdateTime);
+        Assert.Equal(123456, marketDepth.LastUpdateId);
         Assert.Equal(2, marketDepth.Asks.Count());
         Assert.Equal(2, marketDepth.Bids.Count());
         Assert.Equal(50000m, marketDepth.BestAsk.Price);
@@ -116,7 +116,7 @@ public void UpdateDepth_WithOldUpdateTime_IgnoresUpdate()
         marketDepth.UpdateDepth(newAsks, bids, 123400);
 
         // Assert - should still have old data
-        Assert.Equal(123456, marketDepth.LastUpdateTime);
+        Assert.Equal(123456, marketDepth.LastUpdateId);
         Assert.Equal(50000m, marketDepth.BestAsk.Price);
     }