Explicitly include jquery within the application.js package#21
Open
edwinwills wants to merge 1 commit into
Open
Explicitly include jquery within the application.js package#21edwinwills wants to merge 1 commit into
edwinwills wants to merge 1 commit into
Conversation
|
I had this same problem, will this get merged? |
|
Hope we can merge this soon |
Member
|
Hey @edwinwills, thanks for your contribution. Sorry for not answering for a long time. I think it's better to eliminate jQuery in the gem instead of including it in the application.js. I'll try to do it asap. |
|
can we merge this pr ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using a version of Rails that doesn't include jquery by default, and I found that unless I explicitly included the jquery bundled within the Administrate engine within this field's
application.js, the field didn't render in the browser (with an exception related to undefined$).PR'ing my change in case it's useful to merge into the main release.
Thanks for a great gem!