Merge branch 'develop' into art/2000/pii-correlation

Author: ArtOfCode-

.github/workflows/ci-cd.yml

@@ -15,8 +15,8 @@ env:
 permissions:
   actions: write
   contents: read
-  issues: read
-  pull-requests: read
+  issues: write
+  pull-requests: write
 
 jobs:
   rubocop:
@@ -62,7 +62,7 @@ jobs:
 
     services:
       mysql: &db-service
-        image: mysql:8.0
+        image: mysql:8.4.2 # please keep the image in sync with Dockerfile.db
         env:
           MYSQL_ROOT_HOST: '%'
           MYSQL_ROOT_PASSWORD: 'root'
@@ -80,7 +80,13 @@ jobs:
       - name: Setup dependencies
         run: |
           sudo apt-get -qq update
-          sudo apt-get -yqq install libmariadb-dev libmagickwand-dev
+          sudo apt-get -yqq install libmariadb-dev \
+                                    libmagickwand-dev \
+                                    mariadb-client
+      - name: Report database client versions
+        run: |
+          mysql --version
+          mysqldump --version
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -181,3 +187,22 @@ jobs:
               -i ~/.ssh/deploy.key \
               "$SSH_USER"@"$SSH_IP" \
               "sudo su -l qpixel /var/apps/deploy-dev"
+
+  db_changes:
+    name: Check for data dump changes
+    runs-on: ubuntu-latest
+    if: ${{ github.event_name == 'pull_request' && github.actor != 'dependabot[bot]' }}
+
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v3
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.4
+          bundler-cache: true
+      - name: Check for changes
+        run: |
+          bundle exec ruby lib/database_changes_checker.rb origin/${{ github.event.pull_request.base.ref }} \
+            origin/${{ github.event.pull_request.head.ref }} ${{ secrets.GITHUB_TOKEN }} \
+            ${{ github.event.pull_request.number }}

.rubocop.yml

@@ -8,6 +8,7 @@ AllCops:
   Exclude:
     - 'config/**/*'
     - 'db/schema.rb'
+    - 'docker/mysql/**/*'
     - 'scripts/**/*'
     - 'bin/**/*'
     - 'lib/namespaced_env_cache.rb'

Gemfile

@@ -102,6 +102,7 @@ end
 
 group :development, :test do
   gem 'byebug', '~> 11.1'
+  gem 'octokit', '~> 10.0'
 end
 
 group :development do

Gemfile.lock

@@ -164,6 +164,12 @@ GEM
     erb (6.0.3)
     erubi (1.13.1)
     execjs (2.10.1)
+    faraday (2.14.2)
+      faraday-net_http (>= 2.0, < 3.5)
+      json
+      logger
+    faraday-net_http (3.4.3)
+      net-http (~> 0.5)
     fastimage (2.4.1)
     ffi (1.17.4-x86_64-linux-gnu)
     flamegraph (0.9.5)
@@ -251,6 +257,8 @@ GEM
     mutex_m (0.3.0)
     mysql2 (0.5.7)
       bigdecimal
+    net-http (0.9.1)
+      uri (>= 0.11.1)
     net-imap (0.6.3)
       date
       net-protocol
@@ -264,6 +272,9 @@ GEM
     nokogiri (1.19.2-x86_64-linux-gnu)
       racc (~> 1.4)
     observer (0.1.2)
+    octokit (10.0.0)
+      faraday (>= 1, < 3)
+      sawyer (~> 0.9)
     omniauth (2.1.4)
       hashie (>= 3.4.6)
       logger
@@ -412,6 +423,9 @@ GEM
       sprockets (> 3.0)
       sprockets-rails
       tilt
+    sawyer (0.9.3)
+      addressable (>= 2.3.5)
+      faraday (>= 0.17.3, < 3)
     securerandom (0.4.1)
     selenium-webdriver (4.10.0)
       rexml (~> 3.2, >= 3.2.5)
@@ -457,6 +471,7 @@ GEM
     unicode-display_width (3.2.0)
       unicode-emoji (~> 4.1)
     unicode-emoji (4.2.0)
+    uri (1.1.1)
     useragent (0.16.11)
     warden (1.2.9)
       rack (>= 2.0.9)
@@ -528,6 +543,7 @@ DEPENDENCIES
   mutex_m (~> 0.3)
   mysql2 (~> 0.5.4)
   net-smtp (~> 0.3)
+  octokit (~> 10.0)
   omniauth (~> 2.1)
   premailer-rails (~> 1.11)
   puma (~> 5.6)

INSTALLATION.md

@@ -26,6 +26,14 @@ sudo apt install autoconf bison build-essential libssl-dev libyaml-dev libreadli
 sudo apt install mysql-server libmysqlclient-dev
 ```
 
+For Red Hat-Based Linux:
+
+```
+sudo dnf install gcc make pkg-config
+sudo dnf install autoconf bison @development-tools openssl-libs libyaml-devel readline-devel zlibrary-devel ncurses-devel libffi-devel gdbm-devel
+sudo dnf install mysql-server mysql-devel
+```
+
 For Arch-Based Linux:
 
 ```
@@ -131,6 +139,7 @@ the MySQL server with `sudo mysql -u root` and create a new database user for QP
 CREATE USER qpixel@localhost IDENTIFIED BY 'choose_a_password_here';
 GRANT ALL ON qpixel_dev.* TO qpixel@localhost;
 GRANT ALL ON qpixel_test.* TO qpixel@localhost;
+GRANT ALL ON qpixel_dump.* TO qpixel@localhost;
 GRANT ALL ON qpixel.* TO qpixel@localhost;
 ```
 

app/assets/stylesheets/utilities.scss

@@ -381,6 +381,10 @@ span.spoiler {
   white-space: nowrap;
 }
 
+.fit-content {
+  min-width: fit-content;
+}
+
 @each $side in $sides {
   .border-#{$side}-none {
     border-#{$side}: none;

app/controllers/comments_controller.rb

@@ -58,7 +58,7 @@ def create_thread
       notification = "New comment thread on #{@comment.root.title}: #{@comment_thread.title}"
 
       NewThreadFollower.where(post: @post).each do |ntf|
-        unless ntf.user.same_as?(current_user)
+        unless ntf.user.same_as?(current_user) || pings.include?(ntf.user_id)
           ntf.user.create_notification(notification, helpers.comment_link(@comment))
         end
         ThreadFollower.create(user: ntf.user, comment_thread: @comment_thread)
@@ -92,9 +92,8 @@ def create
                                         .where('link LIKE ?', "#{thread_url}%")
         next if existing_notification.exists?
 
-        title = @post.parent.nil? ? @post.title : @post.parent.title
         follower.user.create_notification("There are new comments in a followed thread '#{@comment_thread.title}' " \
-                                          "on the post '#{title}'",
+                                          "on the post '#{@comment.root.title}'",
                                           helpers.comment_link(@comment))
       end
     else
@@ -473,16 +472,15 @@ def restrict_thread_response(thread, status)
 
   # @param pings [Array<Integer>] list of pinged user ids
   def apply_pings(pings)
+    context = @comment_thread.comments.first.same_as?(@comment) ? 'new' : 'comment in the'
+    notification_text =
+      "You were mentioned in a #{context} thread '#{@comment_thread.title}' on the post '#{@comment.root.title}'"
+
     pings.each do |p|
       user = User.where(id: p).first
       next if user.nil?
 
-      next if user.same_as?(@comment.post.user)
-
-      title = @post.parent.nil? ? @post.title : @post.parent.title
-      user.create_notification("You were mentioned in a comment in the thread '#{@comment_thread.title}' " \
-                               "on the post '#{title}'",
-                               helpers.comment_link(@comment))
+      user.create_notification(notification_text, helpers.comment_link(@comment))
     end
   end
 

app/controllers/dumps_controller.rb

@@ -0,0 +1,8 @@
+class DumpsController < ApplicationController
+  before_action :authenticate_user!
+
+  def index
+    @latest = Dump.automatic.last
+    @others = Dump.manual
+  end
+end

app/helpers/application_helper.rb

@@ -250,10 +250,13 @@ def generic_show_link(post)
 
   ##
   # Split a string after a specified number of characters, only breaking at word boundaries.
+  # @deprecated Use {String#truncate}[https://www.rubydoc.info/gems/activesupport/String#truncate-instance_method].
   # @param text [String] The text to split.
   # @param max_length [Integer] The maximum number of characters to leave in the resulting strings.
   # @return [Array<String>]
   def split_words_max_length(text, max_length)
+    logger.warn 'ApplicationHelper#split_words_max_length is deprecated. Use String#truncate instead.'
+    logger.warn caller[0]
     words = text.split
     splat = [[]]
     words.each do |word|

app/helpers/dumps_helper.rb

@@ -0,0 +1,2 @@
+module DumpsHelper
+end