feat: added interactive login for github

Author: kevinwang5658

CLAUDE.md

@@ -258,6 +258,19 @@ const result = await $.spawnSafe('my-tool --version')
 await $.spawn('my-tool configure', { interactive: true })
 ```
 
+**`interactive: true` vs `stdin: true`** — these are distinct options:
+
+- `interactive: true` — passes `-i` to the shell so it sources the user's RC file (`.zshrc`, `.bashrc`). Use this when the command needs PATH entries or shell aliases from the RC. It does **not** allow the user to type input.
+- `stdin: true` — connects the user's terminal stdin directly to the spawned process. Use this when the command requires real user input (e.g. browser-based OAuth prompts, interactive wizards, password entry). Without this flag, interactive prompts will hang.
+
+```typescript
+// Command needs PATH from shell RC but no user input
+await $.spawn('my-tool configure', { interactive: true })
+
+// Command requires the user to interact with it directly (e.g. browser login flow)
+await $.spawn('gh auth login --web', { interactive: true, stdin: true })
+```
+
 **Never use `sudo` inside `$.spawn` or `$.spawnSafe`.** Use `{ requiresRoot: true }` in the options instead. The framework handles privilege escalation through the parent process.
 
 ```typescript

package.json

@@ -1,6 +1,6 @@
 {
   "name": "default",
-  "version": "1.11.0-beta.2",
+  "version": "1.11.0-beta.8",
   "description": "Default plugin for Codify - provides 50+ declarative resources for managing development tools and system configuration across macOS and Linux",
   "main": "dist/index.js",
   "scripts": {

src/resources/github-cli/examples.ts

@@ -1,20 +1,20 @@
 import { ExampleConfig } from '@codifycli/plugin-core';
 
 export const exampleGithubCliBasic: ExampleConfig = {
-  title: 'Install GitHub CLI with SSH configuration',
-  description: 'Install gh and configure it to use SSH for git operations and vim as the default editor.',
+  title: 'Install GitHub CLI with interactive login',
+  description: 'Install gh and log in via browser — no token needed. Use interactiveLogin: true as a shortcut instead of a separate github-cli-auth block.',
   configs: [
     {
       type: 'github-cli',
       gitProtocol: 'ssh',
-      editor: 'vim',
+      interactiveLogin: true,
     },
   ],
 };
 
 export const exampleGithubCliFull: ExampleConfig = {
-  title: 'Full GitHub CLI setup with authentication',
-  description: 'Install gh, authenticate with a personal access token, and configure SSH as the default git protocol.',
+  title: 'GitHub CLI with token authentication',
+  description: 'Install gh, configure SSH as the default git protocol, and authenticate with a personal access token.',
   configs: [
     {
       type: 'github-cli',

src/resources/github-cli/github-cli-auth.ts

@@ -19,7 +19,8 @@ export const schema = z
   .object({
     token: z
       .string()
-      .describe('GitHub personal access token (classic or fine-grained) used for authentication'),
+      .optional()
+      .describe('GitHub personal access token (classic or fine-grained) used for authentication. Omit to use interactive browser-based login'),
     hostname: z
       .string()
       .optional()
@@ -32,6 +33,7 @@ export type GithubCliAuthConfig = z.infer<typeof schema>;
 
 const defaultConfig: Partial<GithubCliAuthConfig> = {
   hostname: 'github.com',
+  token: undefined,
 };
 
 export class GithubCliAuthResource extends Resource<GithubCliAuthConfig> {
@@ -54,7 +56,6 @@ export class GithubCliAuthResource extends Resource<GithubCliAuthConfig> {
       importAndDestroy: {
         requiredParameters: [],
         defaultRefreshValues: {
-          token: '',
           hostname: 'github.com',
         },
       },
@@ -82,11 +83,11 @@ export class GithubCliAuthResource extends Resource<GithubCliAuthConfig> {
     const $ = getPty();
     const hostname = params.hostname ?? 'github.com';
 
-    const { status } = await $.spawnSafe(`gh auth status --hostname ${hostname}`);
+    const { status } = await $.spawnSafe(`gh auth status --hostname "${hostname}"`);
     if (status === SpawnStatus.ERROR) return null;
 
     const { data: tokenData, status: tokenStatus } = await $.spawnSafe(
-      `gh auth token --hostname ${hostname}`
+      `gh auth token --hostname "${hostname}"`
     );
     if (tokenStatus === SpawnStatus.ERROR) return { hostname };
 
@@ -98,39 +99,44 @@ export class GithubCliAuthResource extends Resource<GithubCliAuthConfig> {
 
   async create(plan: CreatePlan<GithubCliAuthConfig>): Promise<void> {
     const { token, hostname = 'github.com' } = plan.desiredConfig;
-    await this.loginWithToken(token, hostname);
+    await this.login(token, hostname);
   }
 
   async modify(
     _pc: unknown,
     plan: ModifyPlan<GithubCliAuthConfig>
   ): Promise<void> {
     const { token, hostname = 'github.com' } = plan.desiredConfig;
-    await this.loginWithToken(token, hostname);
+    await this.login(token, hostname);
   }
 
   async destroy(plan: DestroyPlan<GithubCliAuthConfig>): Promise<void> {
     const $ = getPty();
     const hostname = plan.currentConfig.hostname ?? 'github.com';
 
-    const { data: statusData } = await $.spawnSafe(`gh auth status --hostname ${hostname}`);
+    const { data: statusData } = await $.spawnSafe(`gh auth status --hostname "${hostname}"`);
     const userMatch = statusData.match(/Logged in to \S+ account (\S+)/);
     const username = userMatch?.[1];
 
     if (username) {
-      await $.spawnSafe(`gh auth logout --hostname ${hostname} --user ${username}`);
+      await $.spawnSafe(`gh auth logout --hostname "${hostname}" --user "${username}"`);
     } else {
-      await $.spawnSafe(`gh auth logout --hostname ${hostname}`);
+      await $.spawnSafe(`gh auth logout --hostname "${hostname}"`);
     }
   }
 
-  private async loginWithToken(token: string, hostname: string): Promise<void> {
+  private async login(token: string | undefined, hostname: string): Promise<void> {
     const $ = getPty();
-    const tmpFile = path.join(os.tmpdir(), `.gh-token-${Date.now()}`);
 
+    if (!token) {
+      await $.spawn(`gh auth login --hostname "${hostname}" --web`, { interactive: true, stdin: true });
+      return;
+    }
+
+    const tmpFile = path.join(os.tmpdir(), `.gh-token-${Date.now()}`);
     await fs.writeFile(tmpFile, token.trim(), { mode: 0o600 });
     try {
-      await $.spawn(`gh auth login --with-token --hostname ${hostname} < "${tmpFile}"`, {
+      await $.spawn(`gh auth login --with-token --hostname "${hostname}" < "${tmpFile}"`, {
         interactive: true,
       });
     } finally {

src/resources/github-cli/github-cli.ts

@@ -36,13 +36,17 @@ export const schema = z
       .string()
       .optional()
       .describe('Default web browser for opening URLs'),
+    interactiveLogin: z
+      .boolean()
+      .optional()
+      .describe('If true, runs gh auth login --web after installation for browser-based authentication. Use this as a shortcut instead of declaring a separate github-cli-auth block'),
   })
   .meta({ $comment: 'https://cli.github.com/manual/' })
   .describe('GitHub CLI (gh) — installs gh and manages global configuration');
 
 export type GithubCliConfig = z.infer<typeof schema>;
 
-const CONFIG_KEY_MAP: Record<keyof GithubCliConfig, string> = {
+const CONFIG_KEY_MAP: Partial<Record<keyof GithubCliConfig, string>> = {
   gitProtocol: 'git_protocol',
   editor: 'editor',
   prompt: 'prompt',
@@ -72,6 +76,7 @@ export class GithubCliResource extends Resource<GithubCliConfig> {
         prompt: { canModify: true },
         pager: { canModify: true },
         browser: { canModify: true },
+        interactiveLogin: { type: 'boolean', setting: true },
       },
     };
   }
@@ -116,8 +121,12 @@ export class GithubCliResource extends Resource<GithubCliConfig> {
   }
 
   async create(plan: CreatePlan<GithubCliConfig>): Promise<void> {
+    const $ = getPty();
     await Utils.installViaPkgMgr('gh');
     await this.applyConfig(plan.desiredConfig);
+    if (plan.desiredConfig.interactiveLogin) {
+      await $.spawn('gh auth login --web', { interactive: true, stdin: true });
+    }
   }
 
   async modify(pc: ParameterChange<GithubCliConfig>, _plan: ModifyPlan<GithubCliConfig>): Promise<void> {