feat: updated homebrew resource to support the new tap trust system

Author: kevinwang5658

package-lock.json

@@ -41,7 +41,7 @@
   "license": "ISC",
   "type": "module",
   "dependencies": {
-    "@codifycli/plugin-core": "1.2.5-beta.1",
+    "@codifycli/plugin-core": "^1.2.5-beta.2",
     "@codifycli/schemas": "1.2.0",
     "ajv": "^8.18.0",
     "ajv-formats": "^2.1.1",

package.json

@@ -100,7 +100,7 @@ export class CasksParameter extends StatefulParameter<HomebrewConfig, string[]>
     for (const cask of casksToInstall) {
       const result = await $.spawnSafe(`brew install --casks ${cask}`, {
         interactive: true,
-        env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1, HOMEBREW_NO_REQUIRE_TAP_TRUST: 1 }
+        env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1 }
       })
 
       if (result.status === SpawnStatus.SUCCESS) {
@@ -111,7 +111,7 @@ export class CasksParameter extends StatefulParameter<HomebrewConfig, string[]>
       if (result.data?.includes('It seems there is already an App at')) {
         const adoptResult = await $.spawnSafe(`brew install --casks --adopt ${cask}`, {
           interactive: true,
-          env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1, HOMEBREW_NO_REQUIRE_TAP_TRUST: 1 }
+          env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1 }
         })
 
         if (adoptResult.status === SpawnStatus.SUCCESS) {
@@ -133,7 +133,7 @@ export class CasksParameter extends StatefulParameter<HomebrewConfig, string[]>
     const $ = getPty();
     const result = await $.spawnSafe(`brew uninstall ${casks.join(' ')}`, {
       interactive: true,
-      env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1, HOMEBREW_NO_REQUIRE_TAP_TRUST: 1 }
+      env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1 }
     })
 
     if (result.status === SpawnStatus.SUCCESS) {

src/resources/homebrew/casks-parameter.ts

@@ -61,7 +61,7 @@ export class FormulaeParameter extends StatefulParameter<HomebrewConfig, string[
     const $ = getPty();
     const result = await $.spawnSafe(`brew install --formulae ${formulae.join(' ')}`, {
       interactive: true,
-      env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1, HOMEBREW_NO_REQUIRE_TAP_TRUST: 1 }
+      env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1 }
     })
 
     if (result.status === SpawnStatus.SUCCESS) {
@@ -79,7 +79,7 @@ export class FormulaeParameter extends StatefulParameter<HomebrewConfig, string[
     const $ = getPty();
     const result = await $.spawnSafe(`brew uninstall ${formulae.join(' ')}`, {
       interactive: true,
-      env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1, HOMEBREW_NO_REQUIRE_TAP_TRUST: 1 }
+      env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1 }
     })
 
     if (result.status === SpawnStatus.SUCCESS) {

src/resources/homebrew/formulae-parameter.ts

@@ -51,6 +51,11 @@ export class TapsParameter extends StatefulParameter<HomebrewConfig, string[]> {
         interactive: true,
         env: { HOMEBREW_NO_AUTO_UPDATE: 1, HOMEBREW_NO_ASK: 1, NONINTERACTIVE: 1 },
       });
+      // Homebrew 5.x+ requires taps to be explicitly trusted before their formulae/casks
+      // can be installed by short name. Auto-trust user-declared taps since they've opted in.
+      await $.spawnSafe(`brew trust ${tap}`, {
+        env: { HOMEBREW_NO_AUTO_UPDATE: 1, NONINTERACTIVE: 1 },
+      });
     }
   }