Skip to content

Commit 52b4793

Browse files
committed
Improve TBN chart: dark theme, better colors, regenerated outputs (closes #3)
- Dark theme (#131722) matching TradingView aesthetics - Brighter trendline colors, white-outlined markers - Increased dimensions to 1000x1400px - Regenerated PNG and HTML outputs - Verified docs page accuracy (no changes needed) - Squad logs and decisions updated
1 parent 84be3af commit 52b4793

9 files changed

Lines changed: 174 additions & 64 deletions

.squad/agents/devmeister3000/history.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@
1919
- Three indicator modules used ambiguous variable `l` for low arrays — renamed to `low` in opening_gap.py, strong_weak_high_low.py, volume_imbalance.py. Other modules (like the older ones) used different patterns already.
2020
- `accumulation_distribution_zones` functions were imported in `pyindicators/__init__.py` but missing from `__all__` — added them. This was likely an oversight when the indicator was registered.
2121
- `Optional` was imported but unused in range_intelligence.py (the module uses `Union` instead).
22-
- Pre-existing test failures exist in `test_market_structure` (CHoCH/BOS) — 9 errors unrelated to this work.- **2026-02-27 — TBN analysis notebook (Issue #3):** Created `analysis/indicators/trendline_breakout_navigator.ipynb` following Carlos's chart plan and the VWT notebook pattern. 3-row layout: candlestick + trendlines + markers (row 1, 70%), composite trend bar chart (row 2, 15%), volume bars (row 3, 15%). Outputs HTML, PNG to `static/images/indicators/` and `docs/static/img/indicators/`. `analysis/indicators/` directory is gitignored — used `git add -f` to commit. Stats block prints all 16 keys from `get_trendline_breakout_navigator_stats()`.
22+
- Pre-existing test failures exist in `test_market_structure` (CHoCH/BOS) — 9 errors unrelated to this work.- **2026-02-27 — TBN analysis notebook (Issue #3):** Created `analysis/indicators/trendline_breakout_navigator.ipynb` following Carlos's chart plan and the VWT notebook pattern. 3-row layout: candlestick + trendlines + markers (row 1, 70%), composite trend bar chart (row 2, 15%), volume bars (row 3, 15%). Outputs HTML, PNG to `static/images/indicators/` and `docs/static/img/indicators/`. `analysis/indicators/` directory is gitignored — used `git add -f` to commit. Stats block prints all 16 keys from `get_trendline_breakout_navigator_stats()`.
23+
- **2026-02-28 — TBN dark theme chart overhaul (Issue #3):** Rewrote chart styling from light to dark theme (#131722 background, matching TradingView aesthetic). Key changes: (1) bright green `#00e676` / red `#ff5252` trendlines for contrast against dark background; (2) white-outlined markers (HH triangles, LL triangles, wick diamonds) for visibility; (3) increased chart height to 1000px + width 1400px; (4) Consolas monospace font; (5) subtle grid lines `rgba(255,255,255,0.06)` and muted neutral bars `#363a45` for zero-trend periods; (6) composite trend + volume bars at higher opacity for dark readability. Outputs regenerated to all three paths (HTML + 2× PNG).

.squad/agents/doc-vader/history.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@
1515
- Indicator docs live in `docs/content/indicators/`.
1616
- Analysis notebooks in `analysis/indicators/` serve as visual examples.
1717
- Chart images in docs use UPPER_SNAKE_CASE alt text and path `/img/indicators/<name>.png`, placed immediately after the Example code block's closing fence.
18-
- Added TBN chart image reference to `docs/content/indicators/support-resistance/trendline-breakout-navigator.md` (Issue #3).
18+
- Added TBN chart image reference to `docs/content/indicators/support-resistance/trendline-breakout-navigator.md` (Issue #3).- Verified TBN docs page after chart improvement (Issue #3, 2026-02-28): image ref `![TRENDLINE_BREAKOUT_NAVIGATOR](/img/indicators/trendline_breakout_navigator.png)` correct, PNG exists at both `docs/static/img/indicators/` and `static/images/indicators/` (227 966 bytes), function signatures/params/return columns/signal logic/stats keys all match source. No changes needed.

.squad/decisions.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,3 +45,11 @@
4545
**Issue:** #3
4646
**What:** Created `analysis/indicators/trendline_breakout_navigator.ipynb` following Carlos's spec. PNG output to both `static/images/indicators/` and `docs/static/img/indicators/`. Used `git add -f` for gitignored analysis directory. Composite trend Y-axis hardcoded `[-3.5, 3.5]`.
4747
**Why:** Implements the chart plan. Dual PNG output lets Doc Vader reference the docs copy directly without extra steps.
48+
49+
---
50+
51+
### 2026-02-28T12:00:00Z: TBN Chart Dark Theme Overhaul
52+
**By:** DevMeister3000 (Core Dev)
53+
**Issue:** #3
54+
**What:** Switched TBN analysis notebook chart from light theme to professional dark theme (#131722 background). Updated all colors, opacities, markers, grid lines, and fonts for dark-background readability. Chart dimensions increased to 1000×1400px.
55+
**Why:** Existing light-themed chart was flagged as wrong/ugly. Dark themes are standard in financial charting tools and provide better contrast for overlaid trendlines and markers. Establishes precedent: future indicator analysis notebooks should use this dark theme palette for visual consistency.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# Session Log — Issue #3: TBN Chart Improvement
2+
3+
- **Timestamp:** 2026-02-28T12:00:00Z
4+
- **Issue:** #3 — Improve Trendline Breakout Navigator chart
5+
6+
## Agents
7+
8+
| Agent | Task | Status |
9+
|-------|------|--------|
10+
| DevMeister3000 | Dark theme, brighter colors, larger dimensions, regenerate outputs | ✅ Done |
11+
| Doc Vader | Verify docs page accuracy | ✅ Done (no changes) |
12+
13+
## Outcome
14+
15+
TBN chart updated to professional dark theme (#131722), brighter trendline colors, white-outlined markers, 1000×1400px. PNG and HTML regenerated. Docs page verified accurate — no edits required.
16+
17+
## Decision
18+
19+
Dark theme palette established as precedent for future indicator analysis notebooks (see `decisions.md`).
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# Orchestration Log — DevMeister3000
2+
3+
- **Timestamp:** 2026-02-28T12:00:00Z
4+
- **Agent:** DevMeister3000 (Core Dev)
5+
- **Issue:** #3 — Improve Trendline Breakout Navigator chart
6+
- **Task:** Improve TBN chart visuals
7+
8+
## Summary
9+
10+
Switched TBN analysis notebook chart to dark theme (#131722 background), updated trendline colors to brighter palette, added white-outlined markers, increased chart dimensions to 1000×1400px. Regenerated PNG and HTML outputs.
11+
12+
## Files Changed
13+
14+
- `analysis/indicators/trendline_breakout_navigator.ipynb` — updated chart styling
15+
- `analysis/indicators/trendline_breakout_navigator.html` — regenerated HTML export
16+
- `static/images/indicators/trendline_breakout_navigator.png` — regenerated PNG
17+
- `docs/static/img/indicators/trendline_breakout_navigator.png` — regenerated PNG (docs copy)
18+
19+
## Status
20+
21+
✅ Complete
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Orchestration Log — Doc Vader
2+
3+
- **Timestamp:** 2026-02-28T12:00:00Z
4+
- **Agent:** Doc Vader (DevRel)
5+
- **Issue:** #3 — Improve Trendline Breakout Navigator chart
6+
- **Task:** Verify TBN docs page accuracy
7+
8+
## Summary
9+
10+
Verified `docs/content/indicators/support-resistance/trendline-breakout-navigator.md` — chart image reference path is correct, all function signatures and parameters match current code, column descriptions are accurate. No changes needed.
11+
12+
## Files Verified
13+
14+
- `docs/content/indicators/support-resistance/trendline-breakout-navigator.md` — correct, no edits required
15+
16+
## Status
17+
18+
✅ Complete — no changes needed

analysis/indicators/trendline_breakout_navigator.html

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)