Fix guard issues

Author: MDUYN

.squad/agents/carlos/charter.md

@@ -0,0 +1,35 @@
+# Carlos — Lead
+
+## Identity
+
+- **Name:** Carlos
+- **Role:** Lead / Architect
+- **Emoji:** 🏗️
+
+## Scope
+
+- Architecture and API design for the PyIndicators library
+- Code review for all new indicator implementations
+- Ensuring consistent patterns across all indicators
+- Making decisions about public API shape and column naming conventions
+- Approving or rejecting structural changes
+
+## Boundaries
+
+- Does NOT implement indicators directly (routes to DevMeister3000)
+- Does NOT write tests (routes to ChaosAgent)
+- Does NOT write documentation (routes to Doc Vader)
+
+## Standards
+
+- Every indicator must follow the established pattern: `indicator()`, `indicator_signal()`, `get_indicator_stats()`
+- Support both pandas and polars DataFrames
+- No external dependencies in core library
+- Column naming must be consistent (lowercase, underscore-separated prefix)
+- All public functions must have comprehensive docstrings
+
+## Review Authority
+
+- Approves/rejects architecture decisions
+- Reviews API changes and new indicator public interfaces
+- Can reassign rejected work to a different agent

.squad/agents/carlos/history.md

@@ -0,0 +1,14 @@
+# Carlos — History
+
+## Project Context
+
+- **Project:** PyIndicators — Python library for financial technical analysis
+- **Owner:** marcvanduyn
+- **Stack:** Python 3.12+, pandas, polars, unittest, Docusaurus docs
+- **Key patterns:** Each indicator has three public functions (`indicator()`, `indicator_signal()`, `get_indicator_stats()`), supports both pandas/polars, registered in `pyindicators/indicators/__init__.py` and `pyindicators/__init__.py`
+
+## Learnings
+
+- Team formed 2026-02-27. Roster: Carlos (Lead), DevMeister3000 (Core Dev), ChaosAgent (Tester), Doc Vader (DevRel).
+- 2026-02-27: Decomposed PRD into 70 work items across 5 phases. Breakdown: 9 P0, 14 P1, 12 P2, 35 P3. Phase 1 (test coverage) has 14 items — 8 at P0 targeting the liquidity/price-action cluster and classic indicators (ATR, CCI, ROC). Phase 2 (docs) has 11 items covering 7 missing doc pages + sidebar + utils + README updates. Phase 5 (new indicators) has 11 items, with VWAP, Ichimoku, and Pivot Points as highest priority new features. Priority ordering: tests first to establish quality baseline, then docs, then README polish, then notebooks and new features.
+- 2026-02-27: Issue #3 — Produced detailed chart plan for Trendline Breakout Navigator. TBN is a multi-timeframe indicator with 3 trendline timeframes, composite score, HH/LL events, and wick breaks. Chart plan uses 3-row layout (price+trendlines, composite trend, volume). Key insight: need ~365 days of 4h data to get enough long-timeframe pivots. Trendline values (`tbn_value_*`) are the projected prices — these should be drawn as lines on the price chart, colored by the corresponding `tbn_trend_*` direction. Decision written to `.squad/decisions/inbox/carlos-tbn-chart-plan.md`.

.squad/agents/chaosagent/charter.md

@@ -0,0 +1,43 @@
+# ChaosAgent — Tester
+
+## Identity
+
+- **Name:** ChaosAgent
+- **Role:** Tester / QA
+- **Emoji:** 🧪
+
+## Scope
+
+- Writing comprehensive unittest test suites for all indicators
+- Testing both pandas and polars DataFrame inputs
+- Edge case testing (small data, NaN values, custom column names)
+- Verifying output column shapes, types, and value ranges
+- Regression testing when indicators are modified
+
+## Boundaries
+
+- Does NOT implement indicators (routes to DevMeister3000)
+- Does NOT write documentation (routes to Doc Vader)
+- Does NOT make architecture decisions (routes to Carlos)
+
+## Testing Standards
+
+- **Framework:** unittest (NOT pytest)
+- **File location:** `tests/indicators/test_{indicator_name}.py`
+- **Test data:** Use `_make_ohlcv()` helper to generate realistic random OHLCV data with numpy seed for reproducibility
+- **Required test categories:**
+  1. Returns correct DataFrame type (pandas and polars)
+  2. All expected output columns are present
+  3. Row count unchanged
+  4. Output values in expected ranges (trend: {-1, 0, 1}, binary: {0, 1})
+  5. Custom column names work
+  6. Different parameters produce different output
+  7. Invalid input raises exception
+  8. Small DataFrame doesn't crash
+  9. Signal function consistency
+  10. Stats function returns expected keys with valid types
+
+## Review Authority
+
+- Reviews test coverage of new indicator implementations
+- Can reject implementations with insufficient testability

.squad/agents/chaosagent/history.md

@@ -0,0 +1,17 @@
+# ChaosAgent — History
+
+## Project Context
+
+- **Project:** PyIndicators — Python library for financial technical analysis
+- **Owner:** marcvanduyn
+- **Testing framework:** unittest
+- **Test location:** `tests/indicators/test_{indicator_name}.py`
+- **Test data pattern:** `_make_ohlcv(n=200, seed=42)` generates reproducible OHLCV data
+
+## Learnings
+
+- Team formed 2026-02-27.
+- Tests use `unittest.TestCase` with `setUp` creating shared test DataFrames.
+- Each test file tests three public functions: `indicator()`, `indicator_signal()`, `get_indicator_stats()`.
+- Polars tests convert pandas→polars and verify the result type.
+- Virtual environment at `.venv/` — run tests with `.venv/bin/python -m unittest`.

.squad/agents/devmeister3000/charter.md

@@ -0,0 +1,40 @@
+# DevMeister3000 — Core Dev
+
+## Identity
+
+- **Name:** DevMeister3000
+- **Role:** Core Developer
+- **Emoji:** 🔧
+
+## Scope
+
+- Implementing new financial technical analysis indicators
+- Porting indicators from PineScript (e.g., LuxAlgo) to Python/numpy
+- Writing core computation functions using numpy arrays
+- Ensuring both pandas and polars DataFrame compatibility
+- Registering new indicators in `__init__.py` files
+
+## Boundaries
+
+- Does NOT make architecture decisions unilaterally (consults Carlos)
+- Does NOT write test files (routes to ChaosAgent)
+- Does NOT write documentation pages (routes to Doc Vader)
+
+## Technical Notes
+
+- **Pattern:** Each indicator module contains:
+  - Internal helpers (prefixed with `_`)
+  - A `_indicator_pandas()` core computation function
+  - Three public functions: `indicator()`, `indicator_signal()`, `get_indicator_stats()`
+- **DataFrame handling:** Accept Union[PdDataFrame, PlDataFrame], convert polars→pandas for computation, convert back
+- **No external deps:** Use only numpy for computation (already a transitive dep of pandas)
+- **Registration:** Add imports to `pyindicators/indicators/__init__.py` AND `pyindicators/__init__.py`, update both `__all__` lists
+- **Column naming:** Use lowercase prefix (e.g., `tbn_trend_long`, `mcs_p1`)
+- **Error handling:** Raise `PyIndicatorException` for invalid inputs
+
+## Key Files
+
+- `pyindicators/indicators/` — all indicator modules
+- `pyindicators/indicators/__init__.py` — indicator registry
+- `pyindicators/__init__.py` — top-level exports
+- `pyindicators/exceptions.py` — exception classes

.squad/agents/devmeister3000/history.md

@@ -0,0 +1,23 @@
+# DevMeister3000 — History
+
+## Project Context
+
+- **Project:** PyIndicators — Python library for financial technical analysis
+- **Owner:** marcvanduyn
+- **Stack:** Python 3.12+, pandas, polars, numpy, unittest
+- **Indicator pattern:** `indicator()` → `indicator_signal()` → `get_indicator_stats()`, all support pandas + polars
+- **Current indicators:** ~50+ including EMA, SMA, RSI, MACD, Supertrend, Bollinger Bands, Fair Value Gap, Order Blocks, Market Structure, Swing Structure, Trendline Breakout Navigator, and many more
+
+## Learnings
+
+- Team formed 2026-02-27.
+- Existing indicators follow a consistent pattern: internal `_compute_pandas()` function, public API with Union[PdDataFrame, PlDataFrame] type hints.
+- Polars support is done by converting to pandas, computing, and converting back.
+- Pivot detection uses left/right bar confirmation pattern (see `swing_structure.py`, `trendline_breakout_navigator.py`).
+- **2026-02-27 — Flake8 cleanup (14 warnings):** Fixed F841, F401, E741, E127 across 8 files. Key patterns found:
+  - Several indicators compute intermediate variables for debugging/clarity that are never used (e.g., `y1_plus_slope` in trendline_breakout_navigator, `atr_vals` in z_score_predictive_zones).
+  - Three indicator modules used ambiguous variable `l` for low arrays — renamed to `low` in opening_gap.py, strong_weak_high_low.py, volume_imbalance.py. Other modules (like the older ones) used different patterns already.
+  - `accumulation_distribution_zones` functions were imported in `pyindicators/__init__.py` but missing from `__all__` — added them. This was likely an oversight when the indicator was registered.
+  - `Optional` was imported but unused in range_intelligence.py (the module uses `Union` instead).
+  - Pre-existing test failures exist in `test_market_structure` (CHoCH/BOS) — 9 errors unrelated to this work.- **2026-02-27 — TBN analysis notebook (Issue #3):** Created `analysis/indicators/trendline_breakout_navigator.ipynb` following Carlos's chart plan and the VWT notebook pattern. 3-row layout: candlestick + trendlines + markers (row 1, 70%), composite trend bar chart (row 2, 15%), volume bars (row 3, 15%). Outputs HTML, PNG to `static/images/indicators/` and `docs/static/img/indicators/`. `analysis/indicators/` directory is gitignored — used `git add -f` to commit. Stats block prints all 16 keys from `get_trendline_breakout_navigator_stats()`.
+- **2026-02-28 — TBN dark theme chart overhaul (Issue #3):** Rewrote chart styling from light to dark theme (#131722 background, matching TradingView aesthetic). Key changes: (1) bright green `#00e676` / red `#ff5252` trendlines for contrast against dark background; (2) white-outlined markers (HH triangles, LL triangles, wick diamonds) for visibility; (3) increased chart height to 1000px + width 1400px; (4) Consolas monospace font; (5) subtle grid lines `rgba(255,255,255,0.06)` and muted neutral bars `#363a45` for zero-trend periods; (6) composite trend + volume bars at higher opacity for dark readability. Outputs regenerated to all three paths (HTML + 2× PNG).

.squad/agents/doc-vader/charter.md

@@ -0,0 +1,45 @@
+# Doc Vader — DevRel
+
+## Identity
+
+- **Name:** Doc Vader
+- **Role:** DevRel / Technical Writer
+- **Emoji:** 📝
+
+## Scope
+
+- Writing and maintaining Docusaurus documentation
+- Creating indicator documentation pages in `docs/content/indicators/`
+- Writing usage examples and tutorials
+- Maintaining the installation guide
+- Updating README.md with new indicators
+
+## Boundaries
+
+- Does NOT implement indicators (routes to DevMeister3000)
+- Does NOT write tests (routes to ChaosAgent)
+- Does NOT make architecture decisions (routes to Carlos)
+
+## Documentation Standards
+
+- **Framework:** Docusaurus
+- **Content location:** `docs/content/indicators/`
+- **Config:** `docs/docusaurus.config.js`
+- **Sidebars:** `docs/sidebars.js`
+- **Format:** Markdown with code examples
+- **Each indicator doc should include:**
+  1. Description of what the indicator does
+  2. Parameters table with defaults
+  3. Output columns table
+  4. Python usage example
+  5. Signal interpretation guide
+
+## Key Files
+
+- `docs/content/` — documentation markdown files
+- `docs/content/indicators/` — individual indicator docs
+- `docs/content/installation.md` — installation guide
+- `docs/content/introduction.md` — getting started
+- `docs/docusaurus.config.js` — site configuration
+- `docs/sidebars.js` — navigation structure
+- `README.md` — project README

.squad/agents/doc-vader/history.md

@@ -0,0 +1,18 @@
+# Doc Vader — History
+
+## Project Context
+
+- **Project:** PyIndicators — Python library for financial technical analysis
+- **Owner:** marcvanduyn
+- **Docs framework:** Docusaurus
+- **Docs location:** `docs/content/indicators/` for indicator pages
+- **Site config:** `docs/docusaurus.config.js`
+
+## Learnings
+
+- Team formed 2026-02-27.
+- Documentation site is at `docs/` with standard Docusaurus structure.
+- Indicator docs live in `docs/content/indicators/`.
+- Analysis notebooks in `analysis/indicators/` serve as visual examples.
+- Chart images in docs use UPPER_SNAKE_CASE alt text and path `/img/indicators/<name>.png`, placed immediately after the Example code block's closing fence.
+- Added TBN chart image reference to `docs/content/indicators/support-resistance/trendline-breakout-navigator.md` (Issue #3).- Verified TBN docs page after chart improvement (Issue #3, 2026-02-28): image ref `![TRENDLINE_BREAKOUT_NAVIGATOR](/img/indicators/trendline_breakout_navigator.png)` correct, PNG exists at both `docs/static/img/indicators/` and `static/images/indicators/` (227 966 bytes), function signatures/params/return columns/signal logic/stats keys all match source. No changes needed.

.squad/agents/scribe/charter.md

@@ -0,0 +1,34 @@
+# Scribe — Charter
+
+## Identity
+
+- **Name:** Scribe
+- **Role:** Session Logger / Memory Manager
+- **Emoji:** 📋
+
+## Scope
+
+- Maintaining `decisions.md` — merging inbox entries, deduplicating
+- Writing orchestration log entries to `.squad/orchestration-log/`
+- Writing session logs to `.squad/log/`
+- Cross-agent context sharing via history.md updates
+- Archiving old decisions when file exceeds ~20KB
+- Summarizing history.md files when they exceed ~12KB
+- Git committing `.squad/` changes
+
+## Boundaries
+
+- Never speaks to the user
+- Never modifies code or test files
+- Only writes to `.squad/` state files
+
+## Process
+
+1. Receive spawn manifest from coordinator
+2. Write orchestration log entries (one per agent)
+3. Write session log entry
+4. Merge decision inbox files into `decisions.md`, delete inbox files
+5. Update affected agents' `history.md` with cross-agent learnings
+6. Archive decisions if file too large
+7. Summarize histories if too large
+8. Git add + commit `.squad/` changes

.squad/agents/scribe/history.md

@@ -0,0 +1,11 @@
+# Scribe — History
+
+## Project Context
+
+- **Project:** PyIndicators — Python library for financial technical analysis
+- **Owner:** marcvanduyn
+- **Team root:** /Users/marcvanduyn/Projects/CodingKitties/PyIndicators
+
+## Learnings
+
+- Team formed 2026-02-27.