fix: resolve Windows database locking and Unicode encoding issues

- Call teardown_sqlalchemy() before os.remove() in initialize_storage()
  to release SQLite file locks on Windows (PermissionError WinError 32)
- Use remove_database_if_exists=True in test setUp to prevent stale DB
  state between tests
- Replace manual os.remove/os.rmdir loops with shutil.rmtree in web
  controller test teardowns
- Open verbose output file with encoding='utf-8' in
  validate_backtest_checkpoints to fix UnicodeEncodeError on Windows
  (cp1252 cannot encode checkmark/cross characters)

Author: MDUYN

investing_algorithm_framework/app/app.py

@@ -368,6 +368,13 @@ def initialize_storage(self, remove_database_if_exists: bool = False):
                 logger.info(
                     f"Removing existing database at {database_path}"
                 )
+
+                # Dispose the existing engine to release file locks
+                # (required on Windows where locks are mandatory)
+                from investing_algorithm_framework.infrastructure.database \
+                    import teardown_sqlalchemy
+                teardown_sqlalchemy()
+
                 os.remove(database_path)
 
         # Create the sqlalchemy database uri

investing_algorithm_framework/cli/validate_backtest_checkpoints.py

@@ -50,7 +50,7 @@ def validate_and_create_checkpoints(
     verbose_file_handle = None
 
     if verbose_output_file is not None:
-        verbose_file_handle = open(verbose_output_file, 'w')
+        verbose_file_handle = open(verbose_output_file, 'w', encoding='utf-8')
 
         def echo(msg):
             verbose_file_handle.write(msg + "\n")

tests/app/web/controllers/order_controller/test_list_orders.py

@@ -1,5 +1,6 @@
 import json
 import os
+import shutil
 
 from investing_algorithm_framework import PortfolioConfiguration, \
     MarketCredential
@@ -33,13 +34,7 @@ def tearDown(self) -> None:
         )
 
         if os.path.exists(database_dir):
-            for root, dirs, files in os.walk(database_dir, topdown=False):
-                for name in files:
-                    os.remove(os.path.join(root, name))
-                for name in dirs:
-                    os.rmdir(os.path.join(root, name))
-
-            os.rmdir(database_dir)
+            shutil.rmtree(database_dir, ignore_errors=True)
 
     def test_list_portfolios(self):
         self.iaf_app.add_strategy(StrategyOne)

tests/app/web/controllers/portfolio_controller/test_list_portfolio.py

@@ -1,5 +1,6 @@
 import json
 import os
+import shutil
 
 from investing_algorithm_framework import MarketCredential, \
     PortfolioConfiguration, DataSource, INDEX_DATETIME
@@ -33,13 +34,7 @@ def tearDown(self) -> None:
         )
 
         if os.path.exists(database_dir):
-            for root, dirs, files in os.walk(database_dir, topdown=False):
-                for name in files:
-                    os.remove(os.path.join(root, name))
-                for name in dirs:
-                    os.rmdir(os.path.join(root, name))
-
-            os.rmdir(database_dir)
+            shutil.rmtree(database_dir, ignore_errors=True)
 
     def test_list_portfolios(self):
         strategy = StrategyOne()

tests/app/web/controllers/position_controller/test_list_positions.py

@@ -1,5 +1,6 @@
 import json
 import os
+import shutil
 
 from investing_algorithm_framework import PortfolioConfiguration, \
     MarketCredential
@@ -33,13 +34,7 @@ def tearDown(self) -> None:
         )
 
         if os.path.exists(database_dir):
-            for root, dirs, files in os.walk(database_dir, topdown=False):
-                for name in files:
-                    os.remove(os.path.join(root, name))
-                for name in dirs:
-                    os.rmdir(os.path.join(root, name))
-
-            os.rmdir(database_dir)
+            shutil.rmtree(database_dir, ignore_errors=True)
 
     def test_list_portfolios(self):
         self.iaf_app.add_strategy(StrategyOne)

tests/resources/test_base.py

@@ -83,7 +83,7 @@ def setUp(self) -> None:
 
         if self.initialize:
             self.app.initialize_config()
-            self.app.initialize_storage()
+            self.app.initialize_storage(remove_database_if_exists=True)
             self.app.initialize_services()
             self.app.initialize_portfolios()
 
@@ -215,7 +215,7 @@ def create_app(self):
 
         if self.initialize:
             self.iaf_app.initialize_config()
-            self.iaf_app.initialize_storage()
+            self.iaf_app.initialize_storage(remove_database_if_exists=True)
             self.iaf_app.initialize_services()
             self.iaf_app.initialize_portfolios()