fix: use os.path.join for Windows path compatibility and fix win_loss_ratio test expectations

- Replace hardcoded forward-slash paths with os.path.join() in test files
- Fix test_win_rate assertions: all-winning trades correctly return inf, not 0.0
- Use existing OHLCV data files instead of downloading

Closes #369

Author: MDUYN

tests/app/backtesting/test_backtest_report.py

@@ -80,7 +80,7 @@ def test_report_json_creation(self):
             risk_free_rate=0.027
         )
         path = os.path.join(
-            self.resource_dir, "backtest_reports_for_testing/test_algorithm_backtest"
+            self.resource_dir, "backtest_reports_for_testing", "test_algorithm_backtest"
         )
         backtest.save(directory_path=path)
 

tests/app/reporting/metrics/test_win_rate.py

@@ -31,7 +31,7 @@ def test_all_winning_trades(self):
             self.create_mock_trade(100),
             self.create_mock_trade(300),
         ]
-        self.assertEqual(get_win_loss_ratio(report.get_trades()), 0.0)
+        self.assertEqual(get_win_loss_ratio(report.get_trades()), float('inf'))
 
     def test_all_losing_trades(self):
         report = MagicMock()
@@ -47,11 +47,11 @@ def test_empty_trade_list(self):
         self.assertEqual(get_win_loss_ratio(report.get_trades()), 0.0)
 
     def test_division_by_zero_loss(self):
-        # Should not happen with realistic data, but test edge case
+        # All trades have non-negative gain, no losing trades -> inf
         report = MagicMock()
         report.get_trades.return_value = [
             self.create_mock_trade(100),
             self.create_mock_trade(200),
-            self.create_mock_trade(0),  # zero gain/loss
+            self.create_mock_trade(0),  # zero gain/loss, not counted as a loss
         ]
-        self.assertEqual(get_win_loss_ratio(report.get_trades()), 0.0)
+        self.assertEqual(get_win_loss_ratio(report.get_trades()), float('inf'))

tests/app/reporting/test_backtest_report.py

@@ -65,8 +65,8 @@ def test_save_without_algorithm(self):
             created_at=datetime.now(tz=timezone.utc)
         )
         data_files = [
-            "tests/resources/market_data_sources_for_testing/OHLCV_BTC-EUR_BINANCE_2h_2023-08-07-07-59_2023-12-02-00-00.csv",
-            "tests/resources/market_data_sources_for_testing/OHLCV_BTC-EUR_BINANCE_15m_2023-12-14-22-00_2023-12-25-00-00.csv",
+            os.path.join("tests", "resources", "market_data_sources_for_testing", "OHLCV_BTC-EUR_BINANCE_2h_2023-08-07-07-59_2023-12-02-00-00.csv"),
+            os.path.join("tests", "resources", "market_data_sources_for_testing", "OHLCV_BTC-EUR_BINANCE_15m_2023-12-14-22-00_2023-12-25-00-00.csv"),
         ]
 
         backtest = Backtest(
@@ -185,4 +185,3 @@ def test_save_with_strategies_directory(self):
         self.assertTrue(
             os.path.exists(os.path.join(backtest_run_dir, "metrics.json"))
         )
-

tests/app/reporting/test_pretty_print_backtest.py

@@ -28,7 +28,8 @@
 #     def test_pretty_print(self):
 #         path = os.path.join(
 #             self.resource_dir,
-#             "backtest_reports_for_testing/test_algorithm_backtest_created-at_2025-04-21-21-21"
+#             "backtest_reports_for_testing",
+#             "test_algorithm_backtest_created-at_2025-04-21-21-21"
 #         )
 #         report = Backtest.open(path)
 #         pretty_print_backtest(report)

tests/app/reporting/test_pretty_print_backtest_orders.py

@@ -27,7 +27,8 @@
 #     def test_pretty_print(self):
 #         path = os.path.join(
 #             self.resource_dir,
-#             "backtest_reports_for_testing/test_algorithm_backtest_created-at_2025-04-21-21-21"
+#             "backtest_reports_for_testing",
+#             "test_algorithm_backtest_created-at_2025-04-21-21-21"
 #         )
 #         backtest = Backtest.open(path)
 #         pretty_print_orders(backtest)

tests/app/reporting/test_pretty_print_backtest_positions.py

@@ -28,7 +28,8 @@
 #     def test_pretty_print(self):
 #         path = os.path.join(
 #             self.resource_dir,
-#             "backtest_reports_for_testing/test_algorithm_backtest_created-at_2025-04-21-21-21"
+#             "backtest_reports_for_testing",
+#             "test_algorithm_backtest_created-at_2025-04-21-21-21"
 #         )
 #         report = Backtest.open(path)
 #         pretty_print_positions(report)

tests/app/reporting/test_pretty_print_backtest_trades.py

@@ -27,7 +27,8 @@
 #     def test_pretty_print(self):
 #         path = os.path.join(
 #             self.resource_dir,
-#             "backtest_reports_for_testing/test_algorithm_backtest_created-at_2025-04-21-21-21"
+#             "backtest_reports_for_testing",
+#             "test_algorithm_backtest_created-at_2025-04-21-21-21"
 #         )
 #         report = Backtest.open(path)
 #         pretty_print_trades(report)

tests/resources/backtest_reports_for_testing/test_algorithm_backtest/runs/backtest_EUR_20231201_20231202/run.json

@@ -1 +1 @@
-{"backtest_start_date": "2023-12-01 00:00:00", "backtest_date_range_name": null, "backtest_end_date": "2023-12-02 00:00:00", "trading_symbol": "EUR", "initial_unallocated": 1000.0, "number_of_runs": 1441, "portfolio_snapshots": [{"metadata": "MetaData()", "portfolio_id": "1", "trading_symbol": "EUR", "pending_value": 0.0, "unallocated": 1000.0, "total_net_gain": 0.0, "total_revenue": 0.0, "total_cost": 0.0, "cash_flow": 0.0, "net_size": 1000.0, "created_at": "2023-12-01T00:00:00+00:00", "total_value": 1000.0}, {"metadata": "MetaData()", "portfolio_id": "1", "trading_symbol": "EUR", "pending_value": 0.0, "unallocated": 1000.0, "total_net_gain": 0.0, "total_revenue": 0.0, "total_cost": 0.0, "cash_flow": 0.0, "net_size": 1000.0, "created_at": "2023-12-02T00:00:00+00:00", "total_value": 1000.0}], "trades": [], "orders": [], "positions": [{"symbol": "EUR", "amount": 1000.0, "cost": 1000.0, "portfolio_id": 1}], "created_at": "2026-03-02 10:44:45", "symbols": [], "number_of_days": 0, "number_of_trades": 0, "number_of_trades_closed": 0, "number_of_trades_open": 0, "number_of_orders": 0, "number_of_positions": 0, "metadata": {}, "signals": {}, "signal_events": []}
+{"backtest_start_date": "2023-12-01 00:00:00", "backtest_date_range_name": null, "backtest_end_date": "2023-12-02 00:00:00", "trading_symbol": "EUR", "initial_unallocated": 1000.0, "number_of_runs": 1441, "portfolio_snapshots": [{"metadata": "MetaData()", "portfolio_id": "1", "trading_symbol": "EUR", "pending_value": 0.0, "unallocated": 1000.0, "total_net_gain": 0.0, "total_revenue": 0.0, "total_cost": 0.0, "cash_flow": 0.0, "net_size": 1000.0, "created_at": "2023-12-01T00:00:00+00:00", "total_value": 1000.0}, {"metadata": "MetaData()", "portfolio_id": "1", "trading_symbol": "EUR", "pending_value": 0.0, "unallocated": 1000.0, "total_net_gain": 0.0, "total_revenue": 0.0, "total_cost": 0.0, "cash_flow": 0.0, "net_size": 1000.0, "created_at": "2023-12-02T00:00:00+00:00", "total_value": 1000.0}], "trades": [], "orders": [], "positions": [{"symbol": "EUR", "amount": 1000.0, "cost": 1000.0, "portfolio_id": 1}], "created_at": "2026-03-11 12:01:51", "symbols": [], "number_of_days": 0, "number_of_trades": 0, "number_of_trades_closed": 0, "number_of_trades_open": 0, "number_of_orders": 0, "number_of_positions": 0, "metadata": {}, "signals": {}, "signal_events": []}