Merge dev to main (v7.30.0)#414
Merged
Merged
Conversation
- Fix get_max_daily_drawdown to compute worst single-day decline instead of peak-to-trough drawdown (was identical to max_drawdown) - Fix get_max_drawdown_duration to count calendar days using timestamps instead of counting snapshot entries - Sort equity curve by created_at in get_equity_curve to ensure chronological order for all downstream metrics - Add 15 new tests for daily drawdown, duration, and consistency
…trics fix: drawdown metrics do not match portfolio snapshot data
…ntervals Add TWENTY_MINUTE (20m), SIX_HOUR (6h), EIGHT_HOUR (8h), and THREE_DAY (3d) enum members to support candle intervals available on Binance, Bybit, OKX, and other major exchanges. Also fix from_string to handle uppercase variants for lowercase hour values (e.g. '6H' -> SIX_HOUR), closing a gap in the existing case-handling logic. Closes #412
…num-members feat: add missing TimeFrame enum members for common exchange candle intervals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge dev to main
Includes all changes from dev since last release:
.squad/files have been excluded from this merge.