fix(data workflow tests): cancel running workflow executions before delete#2703
Open
vincent-cognite wants to merge 5 commits into
Open
fix(data workflow tests): cancel running workflow executions before delete#2703vincent-cognite wants to merge 5 commits into
vincent-cognite wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function _delete_workflow_after_executions_finish to clean up workflows and their versions by cancelling running executions and retrying deletion. Feedback suggests optimizing the cleanup process by tracking already cancelled execution IDs to avoid duplicate API requests and simplifying the workflow version ID parameter.
VerstraeteBert
previously approved these changes
Jun 24, 2026
Contributor
Author
simint issues it seems I've been hammering CI a bit and their clean up routines might not be catching all situations... |
VerstraeteBert
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flaky teardown in the workflow simulator integration test by waiting for and cancelling running executions before deleting the workflow version and workflow. The API rejects deletes while executions are still running (jazz-api#2424), which caused intermittent cleanup failures in
test_upsert_run_delete_with_simulation_task.