test(simint): clean up stale test models to prevent hitting limit#2704
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
- Coverage 93.68% 93.65% -0.03%
==========================================
Files 503 503
Lines 50696 50704 +8
==========================================
- Hits 47494 47488 -6
- Misses 3202 3216 +14
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a cleanup mechanism to delete stale simulator models created more than two hours ago during integration tests. Feedback was provided to ensure type safety and prevent potential runtime errors by checking that created_time is not None before comparing it.
vikramlc
approved these changes
Jun 25, 2026
erlendvollset
approved these changes
Jun 25, 2026
Contributor
|
🦄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a cleanup step in the seed_simulator_models fixture to delete leftover models from prior CI runs before creating a new one. It is to prevent it from hitting limit.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.