Skip to content

Commit 78ff03d

Browse files
committed
fix: clear current range when no text selected
1 parent 54149f8 commit 78ff03d

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

js-extensions/packages/feedback/lib/selection.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,12 @@ let SelectionRenderer: React.FC<SelectionRendererProps> = ({ highlighter, stored
4545
let selection = document.getSelection();
4646
if (!selection) return;
4747

48+
// if no text is selected, clear the current range
49+
if (selection.isCollapsed) {
50+
setCurrRange(null);
51+
return;
52+
}
53+
4854
let anchor = selection.anchorNode;
4955
if (!anchor) return;
5056

@@ -57,7 +63,7 @@ let SelectionRenderer: React.FC<SelectionRendererProps> = ({ highlighter, stored
5763
if (!parentElement.closest(".content") || parentElement.closest(".aquascope, .mdbook-quiz"))
5864
return;
5965

60-
let range = !selection.isCollapsed && selection.rangeCount && selection.getRangeAt(0);
66+
let range = selection.rangeCount && selection.getRangeAt(0);
6167

6268
setCurrRange(range || null);
6369
}, []);

0 commit comments

Comments
 (0)