Skip to content

fix: CdpEvmSmartWalletProvider#719

Merged
CarsonRoscoe merged 7 commits into
mainfrom
fix/cdp-evm-smart-wallet
May 15, 2025
Merged

fix: CdpEvmSmartWalletProvider#719
CarsonRoscoe merged 7 commits into
mainfrom
fix/cdp-evm-smart-wallet

Conversation

@CarsonRoscoe
Copy link
Copy Markdown
Contributor

@CarsonRoscoe CarsonRoscoe commented May 15, 2025 •
edited
Loading

  1. If the owner was a server wallet, we were running into issues where the socket would close
  2. If there was any mismatch between the file and .env vars, the wrong owner might get loaded for a smart wallet, which would fail

This PR addresses those changes

@cb-heimdall
Copy link
Copy Markdown

cb-heimdall commented May 15, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions Bot added wallet provider New wallet provider example New example agent python labels May 15, 2025
@CarsonRoscoe CarsonRoscoe force-pushed the fix/cdp-evm-smart-wallet branch from 691a607 to b64080a Compare May 15, 2025 00:37
@CarsonRoscoe CarsonRoscoe marked this pull request as ready for review May 15, 2025 00:38
@CarsonRoscoe CarsonRoscoe requested a review from murrlincoln as a code owner May 15, 2025 00:38
@CarsonRoscoe CarsonRoscoe requested a review from 0xRAG May 15, 2025 00:39
murrlincoln
murrlincoln previously approved these changes May 15, 2025
View reviewed changes
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 15, 2025
0xRAG
0xRAG previously approved these changes May 15, 2025
View reviewed changes
@CarsonRoscoe CarsonRoscoe merged commit 1a73fe6 into main May 15, 2025
28 checks passed
@CarsonRoscoe CarsonRoscoe deleted the fix/cdp-evm-smart-wallet branch May 15, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xRAG 0xRAG 0xRAG approved these changes

@murrlincoln murrlincoln murrlincoln left review comments

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation example New example agent python wallet provider New wallet provider

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CarsonRoscoe @cb-heimdall @0xRAG @murrlincoln