Fix FeeOps duplicated index issue and improve geth-sdk.

Author: jacquescaocb

examples/ethereum/client/client.go

@@ -46,10 +46,10 @@ func (c *EthereumClient) ParseOps(
 	var ops []*RosettaTypes.Operation
 
 	// Compute fee operations
-	feeOps := services.FeeOps(tx)
+	feeOps := services.FeeOps(tx, sdkTypes.Currency)
 	ops = append(ops, feeOps...)
 
-	traceOps := services.TraceOps(tx.Trace, len(ops))
+	traceOps := services.TraceOps(tx.Trace, len(ops), sdkTypes.Currency)
 	ops = append(ops, traceOps...)
 
 	return ops, nil

mocks/services/client.go

@@ -22,6 +22,7 @@ import (
 	evmClient "github.com/coinbase/rosetta-geth-sdk/client"
 	"github.com/coinbase/rosetta-geth-sdk/configuration"
 	RosettaTypes "github.com/coinbase/rosetta-sdk-go/types"
+	Eth "github.com/ethereum/go-ethereum"
 	"github.com/ethereum/go-ethereum/common"
 	EthTypes "github.com/ethereum/go-ethereum/core/types"
 	"github.com/ethereum/go-ethereum/rpc"
@@ -194,4 +195,10 @@ type Client interface {
 	ParseOps(
 		tx *evmClient.LoadedTransaction,
 	) ([]*RosettaTypes.Operation, error)
+
+	// EstimateGas tries to estimate the gas needed to execute a specific transaction based on
+	// the current pending state of the backend blockchain. There is no guarantee that this is
+	// the true gas limit requirement as other transactions may be added or removed by miners,
+	// but it should provide a basis for setting a reasonable default.
+	EstimateGas(ctx context.Context, msg Eth.CallMsg) (uint64, error)
 }

services/construction/types.go

@@ -130,7 +130,7 @@ func TransferOps(tx *evmClient.LoadedTransaction, startIndex int) []*RosettaType
 	return ops
 }
 
-func FeeOps(tx *evmClient.LoadedTransaction) []*RosettaTypes.Operation {
+func FeeOps(tx *evmClient.LoadedTransaction, native_currency *RosettaTypes.Currency) []*RosettaTypes.Operation {
 	var minerEarnedAmount *big.Int
 	if tx.FeeBurned == nil {
 		minerEarnedAmount = tx.FeeAmount
@@ -157,7 +157,7 @@ func FeeOps(tx *evmClient.LoadedTransaction) []*RosettaTypes.Operation {
 			Account: &RosettaTypes.AccountIdentifier{
 				Address: evmClient.MustChecksum(tx.From.String()),
 			},
-			Amount: evmClient.Amount(new(big.Int).Neg(minerEarnedAmount), sdkTypes.Currency),
+			Amount: evmClient.Amount(new(big.Int).Neg(minerEarnedAmount), native_currency),
 		},
 
 		{
@@ -174,7 +174,7 @@ func FeeOps(tx *evmClient.LoadedTransaction) []*RosettaTypes.Operation {
 			Account: &RosettaTypes.AccountIdentifier{
 				Address: evmClient.MustChecksum(feeRewarder),
 			},
-			Amount: evmClient.Amount(minerEarnedAmount, sdkTypes.Currency),
+			Amount: evmClient.Amount(minerEarnedAmount, native_currency),
 		},
 	}
 
@@ -189,7 +189,7 @@ func FeeOps(tx *evmClient.LoadedTransaction) []*RosettaTypes.Operation {
 		Type:    sdkTypes.FeeOpType,
 		Status:  RosettaTypes.String(sdkTypes.SuccessStatus),
 		Account: evmClient.Account(tx.From),
-		Amount:  evmClient.Amount(new(big.Int).Neg(tx.FeeBurned), sdkTypes.Currency),
+		Amount:  evmClient.Amount(new(big.Int).Neg(tx.FeeBurned), native_currency),
 	}
 
 	ops = append(ops, burntOp)
@@ -203,6 +203,7 @@ func FeeOps(tx *evmClient.LoadedTransaction) []*RosettaTypes.Operation {
 func TraceOps(
 	calls []*evmClient.FlatCall,
 	startIndex int,
+	native_currency *RosettaTypes.Currency,
 ) []*RosettaTypes.Operation { // nolint: gocognit
 	var ops []*RosettaTypes.Operation
 	if len(calls) == 0 {
@@ -250,7 +251,7 @@ func TraceOps(
 				},
 				Amount: &RosettaTypes.Amount{
 					Value:    new(big.Int).Neg(trace.Value).String(),
-					Currency: sdkTypes.Currency,
+					Currency: native_currency,
 				},
 				Metadata: metadata,
 			}
@@ -311,7 +312,7 @@ func TraceOps(
 				},
 				Amount: &RosettaTypes.Amount{
 					Value:    trace.Value.String(),
-					Currency: sdkTypes.Currency,
+					Currency: native_currency,
 				},
 				Metadata: metadata,
 			}
@@ -355,7 +356,7 @@ func TraceOps(
 			},
 			Amount: &RosettaTypes.Amount{
 				Value:    new(big.Int).Neg(val).String(),
-				Currency: sdkTypes.Currency,
+				Currency: native_currency,
 			},
 		})
 	}