Add GitHub Actions workflow with ESLint and Jest#81
Closed
devin-ai-integration[bot] wants to merge 3 commits into
Closed
Add GitHub Actions workflow with ESLint and Jest#81devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
- Add ESLint configuration for code linting - Create CI workflow with lint and test jobs - Test against Node.js 18.x, 20.x, 22.x - Replace Travis CI with GitHub Actions Co-Authored-By: cedric@coingecko.com <cedric@coingecko.com>
Contributor
Author
Original prompt from cedric@coingecko.com |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Change package.json engines to require Node.js >=22 - Remove matrix strategy from GitHub workflow - Test only against Node.js 22.x instead of 18.x, 20.x, 22.x Co-Authored-By: cedric@coingecko.com <cedric@coingecko.com>
- Update lint job from Node.js 20.x to 22.x - Resolves EBADENGINE error in CI where package.json requires >=22 - Both lint and test jobs now consistently use Node.js 22.x Co-Authored-By: cedric@coingecko.com <cedric@coingecko.com>
jasonjul
approved these changes
Aug 28, 2025
Contributor
Author
|
Closing due to inactivity for more than 30 days. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GitHub Actions workflow with ESLint and Jest
Summary
This PR introduces a modern CI/CD pipeline using GitHub Actions to replace the existing Travis CI setup. The workflow includes code linting with ESLint and comprehensive testing across multiple Node.js versions.
Key changes:
The ESLint configuration uses warnings instead of errors for existing code patterns to avoid breaking the build while still providing code quality feedback.
Review & Testing Checklist for Human
npm run lintto ensure ESLint warnings are acceptable and don't indicate real issuesNotes
Link to Devin run: https://app.devin.ai/sessions/f64ceefe350e4a42bf304bfacf32c3f7
Requested by: jason.julian