fix(extraction): index independent nested git repos#201
Open
sjh9714 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codegraph init -i/scan discovery for top-level workspaces that contain independent nested Git repos.git ls-files -o --exclude-standardby enumerating that repo’s own visible files.codegraph init -idoes not detect source files when run from a top-level CMake workspace containing multiple nested repos #193 while preserving existing Git submodule scan behavior.Why
Before this change, a parent Git repo saw an unregistered nested repo as a single
sub_repo1/untracked directory. That directory did not match source include patterns, so top-level workspace scans could report no files even though the nested repo contained source files.Testing
npx vitest run __tests__/extraction.test.ts -t "independent nested git"— failed before the fix withexpected [] to include 'sub_repo1/src/main.cpp'npx vitest run __tests__/extraction.test.ts -t "independent nested git|git submodules"npx vitest run __tests__/extraction.test.tsnpm run buildnpm testgit diff --checkFixes #193
Note: I used Codex to help inspect the scan path and draft the regression test, then reviewed the final diff and ran the listed verification commands locally.