Enhance shimmer progress with performance metrics#202
Open
krataratha wants to merge 1 commit into
Open
Conversation
Added optional fields for estimated time remaining and items per second in IndexProgress interface. Enhanced createShimmerProgress function to calculate and pass performance metrics.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR enhances shimmer indexing progress reporting by adding performance metrics (throughput and ETA) to the progress payload.
Changes:
- Extend
IndexProgresswith optionalestimatedTimeRemainingMsanditemsPerSecond. - Track phase start time and compute metrics on each progress update.
- Post an enriched progress update message to the worker.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+71
to
78
| async stop() { | ||
| await worker.terminate(); | ||
| } | ||
| }; | ||
| } | ||
| lastPhase = progress.phase; | ||
|
|
||
| let percent = -1; |
Comment on lines
+64
to
+68
| worker.postMessage({ | ||
| type: 'progress-update', | ||
| phaseName, | ||
| ...enrichedProgress | ||
| }); |
|
|
||
| export function createShimmerProgress(): ShimmerProgress { | ||
| let lastPhase = ''; | ||
| let phaseStartTime = Date.now(); |
| lastPhase = progress.phase; | ||
|
|
||
| // New Feature: Calculate performance metrics | ||
| const elapsedMs = Date.now() - phaseStartTime; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional fields for estimated time remaining and items per second in IndexProgress interface. Enhanced createShimmerProgress function to calculate and pass performance metrics.