Skip to content

Commit f2b3a34

Browse files
committed
Don't continue with testing if an extension crashes
1 parent af7fa08 commit f2b3a34

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

colcon_core/task/python/test/__init__.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ def add_arguments(self, *, parser): # noqa: D102
2727
add_python_testing_step_arguments(parser)
2828

2929
async def test(self, *, additional_hooks=None): # noqa: D102
30-
pkg = self.context.pkg
3130
args = self.context.args
3231

3332
logger.info(
@@ -59,8 +58,7 @@ async def test(self, *, additional_hooks=None): # noqa: D102
5958
'Exception in Python testing step extension '
6059
"'{extension.STEP_TYPE}': {e}\n{exc}"
6160
.format_map(locals()))
62-
# skip failing extension, continue with next one
63-
continue
61+
return 1
6462
if matched:
6563
break
6664
else:

0 commit comments

Comments
 (0)