debug remote hal

Author: Colin Davidson

.github/actions/do_build_run_remote_hal/action.yml

@@ -14,30 +14,32 @@ runs:
     - name : build client
       shell: bash
       run: |
-        cmake -Bbuild_client -GNinja -DCA_MUX_TARGETS_TO_ENABLE="riscv" -DCA_RISCV_ENABLED=ON -DCA_LLVM_INSTALL_DIR=$GITHUB_WORKSPACE/llvm_install -DCA_CL_ENABLE_ICD_LOADER=ON -DCA_HAL_NAME=cpu_client
+        cmake -Bbuild_client -GNinja -DCA_MUX_TARGETS_TO_ENABLE="riscv" -DCA_RISCV_ENABLED=ON -DCA_LLVM_INSTALL_DIR=$GITHUB_WORKSPACE/llvm_install -DCA_CL_ENABLE_ICD_LOADER=ON -DCA_HAL_NAME=cpu_client -DCA_CL_ENABLE_OFFLINE_KERNEL_TESTS=OFF
         ninja -Cbuild_client UnitCL
     - name : run remote_hal
       shell: bash
       run: |
         export HAL_REMOTE_PORT=9999
+        export HAL_DEBUG_SERVER=1
         # Limit number of threads to 1 due to hal cpu use of temporary threads causing excessive qemu memory usage.
         export CA_CPU_HAL_NUM_THREADS=1
         export START_STRING="Listening on port $HAL_REMOTE_PORT"
         export TRIES=10
         # Start server
         cd build_server
-        ( /usr/bin/qemu-riscv64 -L /usr/riscv64-linux-gnu ./hal_cpu_server_bin $HAL_REMOTE_PORT > /tmp/hal.op 2>&1 ) &
+        ( /usr/bin/qemu-riscv64 -L /usr/riscv64-linux-gnu ./hal_cpu_server_bin $HAL_REMOTE_PORT | tee /tmp/hal.op 2>&1 ) &
         # Check that server is running.
         while [ "$TRIES" -gt 0 ] && ! grep "$START_STRING" /tmp/hal.op ; do
           sleep 1
           TRIES=$(( TRIES - 1 ))
         done
-        rm /tmp/hal.op
+        # rm /tmp/hal.op
         if [ "$TRIES" -ne 0 ]; then
           jobs
           # Run client
           cd $GITHUB_WORKSPACE/build_client
           exitcode=0
+          sleep 2
           OCL_ICD_FILENAMES=$PWD/lib/libCL.so.4.0 ./bin/UnitCL || exitcode=$?
           kill %1
           exit $exitcode

.github/workflows/planned_testing_caller.yml

@@ -83,7 +83,8 @@ permissions:
 jobs:
   build_llvm_artefacts:
     name: Call PR testing on schedule
-    if: inputs.build_llvm && inputs.ock
+    if: inputs.build_llvm
+    # && inputs.ock
     uses: ./.github/workflows/create_llvm_artefacts.yml
     secrets: inherit
     with:

.github/workflows/planned_testing_caller_20.yml

@@ -41,6 +41,16 @@ jobs:
       # We can set ock, test_sycl_cts etc here optionally if this is used as a
       # pull request. Any parameters below this is intended for local testing
       # and should not be merged nor reviewed (other than checking it should not be merged).
+      ock: false
+      test_tornado: false
+      test_sanitizers: false
+      test_remote_hal: true
+      test_sycl_cts: false
+      test_sycl_e2e: false
+      test_opencl_cts: false
+      run_internal: false
+      run_external: true
+      target_list: '[ "host_x86_64_linux"]'
 
   # This cleans up any caches which may have been created when running external tests
   clean_caches:

.github/workflows/run_pr_tests_caller.yml

@@ -3,18 +3,18 @@ name: Run ock tests for PR style testing
 on:
   pull_request:
     paths:
-      - 'source/**'
-      - 'clik/**'
-      - 'modules/**'
-      - 'examples/**'
-      - 'cmake/**'
-      - 'hal/**'
-      - '.github/actions/do_build_ock/**'
-      - '.github/actions/do_build_pr/**'
-      - '.github/actions/setup_build/**'
+      # - 'source/**'
+      # - 'clik/**'
+      # - 'modules/**'
+      # - 'examples/**'
+      # - 'cmake/**'
+      # - 'hal/**'
+      # - '.github/actions/do_build_ock/**'
+      # - '.github/actions/do_build_pr/**'
+      # - '.github/actions/setup_build/**'
       - '.github/workflows/run_ock_internal_tests.yml'
-      - '.github/workflows/run_pr_tests_caller.yml'
-      - 'CMakeLists.txt'
+      # - '.github/workflows/run_pr_tests_caller.yml'
+      # - 'CMakeLists.txt'
 
 permissions:
   packages: read

modules/compiler/loader/source/loader.cpp

@@ -91,6 +91,11 @@ cargo::expected<std::unique_ptr<Library>, std::string> loadLibrary() {
   // See
   // https://stackoverflow.com/questions/51209268/using-stdthread-in-a-library-loaded-with-dlopen-leads-to-a-sigsev
   handle->library = dlopen(library_name, RTLD_NOW | RTLD_GLOBAL);
+  if (! handle->library) {
+    (void)fprintf(stderr, "error: could not load '%s' : '%s'\n", library_name,
+                  dlerror());
+    return nullptr;
+  }  
 #endif
 
   if (!handle->library) {