feat: add native BoxLang 1.8.0+ dynamic class loading support#25

Merged

lmajano merged 4 commits into

developmentfrom

claude/full-code-analysis-65BUo

Mar 31, 2026

Contributor

lmajano commented Mar 31, 2026 •

edited by Copilot AI

Loading

Understand new review comments from @lmajano
setup() (line 37): remove server scope storage and lock for BoxLang – just call getRequestClassLoader().addPaths() directly
appendPaths() (line 89): remove server scope and lock for BoxLang – just use the loader directly
getLoadedURLs() (line 134): get loaded URLs directly from the class loader, not from server scope
getVersion() (line 165): remove the BoxLang-specific "boxlang-native" version string, use the same version as non-BoxLang path
Code review and security check

claude added 2 commits

March 30, 2026 19:50


          feat: add native BoxLang 1.8.0+ dynamic class loading support

ef1ef3f

When running on BoxLang 1.8.0+, bypass JavaLoader entirely and delegate
to BoxLang's built-in getRequestClassLoader().addPaths() / createObject()
APIs, eliminating URLClassLoader overhead and server-scope caching.

- ModuleConfig: skip jl@cbjavaloader binding and cfcdynamicproxy.jar
  prepend on BoxLang (neither is needed with native class loading)
- Loader: add isBoxLangNative() helper (cached, probed via try/catch)
  and BoxLang branches in setup(), create(), appendPaths(),
  getLoadedURLs(), getURLClassLoader(), getVersion()
- LoaderTest: adjust expected URL count (1 on BoxLang, 2 on CF/Lucee)

Falls back gracefully to JavaLoader on BoxLang < 1.8.0 if addPaths()
is unavailable.

https://claude.ai/code/session_01G5FaLgYNxWeRijMwPryJj8


          refactor: simplify isBoxLangNative() - BoxLang is always up to date

733e101

Remove the try/catch version probe. BoxLang is always current so a
simple server.boxlang struct key check is sufficient.

https://claude.ai/code/session_01G5FaLgYNxWeRijMwPryJj8

Copilot AI review requested due to automatic review settings

March 31, 2026 08:50

Copilot started reviewing on behalf of lmajano

March 31, 2026 08:51

github-actions Bot commented Mar 31, 2026 •

edited

Loading

lucee@6 ColdBox be Test Results

4 tests ±0 4 ✅ ±0 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit f0f88eb. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Mar 31, 2026 •

edited

Loading

lucee@5 ColdBox be Test Results

4 tests ±0 4 ✅ ±0 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit f0f88eb. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Mar 31, 2026 •

edited

Loading

lucee@6 ColdBox ^7.0.0 Test Results

4 tests ±0 4 ✅ ±0 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 920c457. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Mar 31, 2026 •

edited

Loading

lucee@5 ColdBox ^7.0.0 Test Results

4 tests ±0 4 ✅ ±0 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit f0f88eb. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Mar 31, 2026 •

edited

Loading

boxlang-cfml@1 ColdBox be Test Results

4 tests ±0 2 ✅ - 2 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0 2 🔥 +2

For more details on these errors, see this check.

Results for commit 920c457. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Mar 31, 2026 •

edited

Loading

boxlang@1 ColdBox be Test Results

4 tests ±0 2 ✅ - 2 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0 2 🔥 +2

For more details on these errors, see this check.

Results for commit 920c457. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Mar 31, 2026 •

edited

Loading

boxlang-cfml@1 ColdBox ^7.0.0 Test Results

4 tests ±0 2 ✅ - 2 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0 2 🔥 +2

For more details on these errors, see this check.

Results for commit 920c457. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Mar 31, 2026 •

edited

Loading

adobe@2025 ColdBox be Test Results

4 tests ±0 4 ✅ ±0 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 920c457. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Mar 31, 2026 •

edited

Loading

adobe@2025 ColdBox ^7.0.0 Test Results

4 tests ±0 4 ✅ ±0 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 920c457. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

github-actions Bot commented Mar 31, 2026 •

edited

Loading

adobe@2023 ColdBox ^7.0.0 Test Results

4 tests ±0 4 ✅ ±0 0s ⏱️ ±0s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 920c457. ± Comparison against base commit 3ec97ff.

♻️ This comment has been updated with latest results.

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull request overview

Adds a BoxLang-native code path to cbjavaloader so BoxLang runtimes can use the built-in request class loader APIs instead of JavaLoader, while keeping the existing JavaLoader behavior for CF/Lucee.

Changes:

Conditionalize jl@cbjavaloader binding and cfcdynamicproxy.jar prepending based on BoxLang detection.
Add BoxLang-native branches in models/Loader.cfc for setup, class creation, path appending, and URL reporting.
Update the Loader test expectation for loaded URL count on BoxLang vs CF/Lucee.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
`ModuleConfig.cfc`	Skips JavaLoader binding and dynamic-proxy jar on BoxLang runtimes.
`models/Loader.cfc`	Implements BoxLang-native class loading branches and a BoxLang detection helper.
`test-harness/tests/specs/LoaderTest.cfc`	Adjusts expected loaded URL count for BoxLang vs CF/Lucee.

models/Loader.cfc

models/Loader.cfc Outdated

models/Loader.cfc

ModuleConfig.cfc Outdated

test-harness/tests/specs/LoaderTest.cfc


          Apply suggestions from code review

920c457

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

lmajano commented

View reviewed changes

models/Loader.cfc Outdated

models/Loader.cfc Outdated

models/Loader.cfc Outdated

models/Loader.cfc Outdated

Copilot started work on behalf of lmajano

March 31, 2026 09:31


          refactor: remove server scope and locks from BoxLang native class loa…

f0f88eb

…ding paths

Agent-Logs-Url: https://github.com/coldbox-modules/cbjavaloader/sessions/618d75fc-d52b-4f89-9293-5a5fb15482d7

Co-authored-by: lmajano <137111+lmajano@users.noreply.github.com>

Copilot finished work on behalf of lmajano

March 31, 2026 09:46

lmajano merged commit 805a053 into development

18 of 26 checks passed

lmajano deleted the claude/full-code-analysis-65BUo branch

March 31, 2026 10:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet