Fix more async flakiness

Author: elpete

server-adobe@2021.json

@@ -1,23 +1,23 @@
 {
-  "name": "cordial-sdk-adobe@2021",
-  "app": {
-    "serverHomeDirectory": ".engine/adobe2021",
-    "cfengine": "adobe@2021"
-  },
-  "web": {
-    "http": {
-      "port": "60298"
+    "name":"cordial-sdk-adobe@2021",
+    "app":{
+        "serverHomeDirectory":".engine/adobe2021",
+        "cfengine":"adobe@2021"
     },
-    "rewrites": {
-      "enable": "true"
+    "web":{
+        "http":{
+            "port":"60298"
+        },
+        "rewrites":{
+            "enable":"true"
+        }
+    },
+    "jvm":{
+        "heapSize":"1024",
+        "javaVersion":"openjdk11_jre"
+    },
+    "openBrowser":"false",
+    "scripts":{
+        "onServerInstall":"cfpm install zip,debugger"
     }
-  },
-  "jvm": {
-    "heapSize": "1024",
-    "javaVersion": "openjdk11_jre"
-  },
-  "openBrowser": "false",
-  "scripts": {
-    "onServerInstall": "cfpm install zip,debugger"
-  }
 }

tests/specs/unit/SubscriptionsSpec.cfc

@@ -260,13 +260,15 @@ component extends="tests.resources.ModuleIntegrationSpec" appMapping="/app" {
             } );
 
             it( "handles async future failures and returns mixed results", function() {
+                variables.fakeInvocationCount = 0;
                 variables.hyper
                     .fake( {
                         "/v2/contacts": function( newFakeResponse, req ) {
-                            return [
-                                newFakeResponse( 500, "Internal Server Error", "{}" ),
-                                newFakeResponse( 201, "Created", "{}" )
-                            ];
+                            variables.fakeInvocationCount++;
+                            if ( variables.fakeInvocationCount == 1 ) {
+                                throw( type = "AsyncFutureBoom", message = "Boom from fake response callback" );
+                            }
+                            return newFakeResponse( 201, "Created", "{}" );
                         }
                     } )
                     .preventStrayRequests();
@@ -285,15 +287,15 @@ component extends="tests.resources.ModuleIntegrationSpec" appMapping="/app" {
                     return !item.success;
                 } );
                 expect( failedResults ).toHaveLength( 1 );
-                expect( failedResults[ 1 ].statusCode ).toBe( 500 );
-                expect( failedResults[ 1 ].error ).toInclude( "Internal Server Error" );
-                expect(
-                    result.results
-                        .map( function( item ) {
-                            return item.subscriber;
-                        } )
-                        .sort( "textnocase" )
-                ).toBe( [ "explode@example.com", "ok@example.com" ].sort( "textnocase" ) );
+                expect( failedResults[ 1 ].statusCode ).toBe( 0 );
+                expect( failedResults[ 1 ].error ).toInclude( "Boom from fake response callback" );
+                var actualSubscribers = result.results.map( function( item ) {
+                    return item.subscriber;
+                } );
+                var expectedSubscribers = [ "explode@example.com", "ok@example.com" ];
+                arraySort( actualSubscribers, "textnocase" );
+                arraySort( expectedSubscribers, "textnocase" );
+                expect( actualSubscribers ).toBe( expectedSubscribers );
             } );
 
             it( "falls back to sequential sends when async manager is missing", function() {