fix(postgres): normalize cast shorthand in default expressions

Author: elpete

models/Grammars/PostgresGrammar.cfc

@@ -339,14 +339,32 @@ component extends="qb.models.Grammars.BaseGrammar" singleton {
     }
 
     function wrapDefaultType( column ) {
+        var defaultValue = column.getDefaultValue();
+        // Normalize PostgreSQL cast shorthand (value::TYPE) so runtimes that
+        // parse ":" for named params don't break schema DDL execution.
+        var castPosition = 0;
+        for ( var i = len( defaultValue ) - 1; i >= 1; i-- ) {
+            if ( mid( defaultValue, i, 2 ) == "::" ) {
+                castPosition = i;
+                break;
+            }
+        }
+        if ( castPosition > 0 ) {
+            var valuePart = trim( left( defaultValue, castPosition - 1 ) );
+            var typePart = trim( mid( defaultValue, castPosition + 2, len( defaultValue ) ) );
+            if ( typePart != "" ) {
+                defaultValue = "CAST(#valuePart# AS #typePart#)";
+            }
+        }
+
         switch ( column.getType() ) {
             case "boolean":
-                return uCase( column.getDefaultValue() );
+                return uCase( defaultValue );
             case "char":
             case "string":
-                return "'#column.getDefaultValue()#'";
+                return "'#defaultValue#'";
             default:
-                return column.getDefaultValue();
+                return defaultValue;
         }
     }
 

tests/specs/Schema/PostgresSchemaBuilderSpec.cfc

@@ -1,5 +1,24 @@
 component extends="tests.resources.AbstractSchemaBuilderSpec" {
 
+    function run() {
+        super.run();
+
+        describe( "postgres specific behavior", function() {
+            it( "normalizes cast shorthand in default expressions", function() {
+                testCase( function( schema ) {
+                    return schema.create(
+                        "expenses",
+                        function( table ) {
+                            table.jsonb( "extracted_data" ).default( "'{}'::JSONB" );
+                        },
+                        {},
+                        false
+                    );
+                }, defaultForJsonbCastShorthand() );
+            } );
+        } );
+    }
+
     function emptyTable() {
         return [ "CREATE TABLE ""users"" ()" ];
     }
@@ -636,6 +655,10 @@ component extends="tests.resources.AbstractSchemaBuilderSpec" {
         return [ "CREATE TABLE ""active_users"" AS (SELECT * FROM ""users"" WHERE ""active"" = ?)" ];
     }
 
+    function defaultForJsonbCastShorthand() {
+        return [ "CREATE TABLE ""expenses"" (""extracted_data"" JSONB NOT NULL DEFAULT CAST('{}' AS JSONB))" ];
+    }
+
     private function getBuilder( mockGrammar ) {
         var utils = getMockBox().createMock( "qb.models.Query.QueryUtils" );
         arguments.mockGrammar = isNull( arguments.mockGrammar ) ? getMockBox()