Skip to content

[Security] Fix CodeQL alert #33: XML internal entity expansion #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colin-d-fried wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Security] Fix CodeQL alert #33: XML internal entity expansion #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vulnerable_xxe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ def upload_xml():
xml_file = request.files['file']
content = xml_file.read()

root = ET.fromstring(content)
import defusedxml.ElementTree as SafeET
root = SafeET.fromstring(content)

@cursor cursor Bot Mar 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing defusedxml dependency in project Pipfile

High Severity

The fix imports defusedxml.ElementTree but defusedxml is not declared as a dependency in Pipfile (or Pipfile.lock). This means the /upload_xml endpoint will raise an ImportError at runtime because the package won't be installed in the environment. The security fix effectively breaks the endpoint entirely.

Fix in Cursor Fix in Web


return f"Uploaded: {root.tag}"

Expand Down
Loading