Skip to content

[Security] Fix CodeQL alert #35: Deserialization of user-controlled data #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colin-d-fried wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Security] Fix CodeQL alert #35: Deserialization of user-controlled data #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vulnerable_deserialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ def load_data():
def restore_session():
session_data = request.form.get('session')

session = pickle.loads(session_data.encode())
import json as _json
session = _json.loads(session_data)

@cursor cursor Bot Mar 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary inline import with unconventional alias

Low Severity

The json module is imported inside the function body and aliased as _json, even though there is no naming conflict with json in this file. The underscore-prefixed alias is unconventional and misleading (suggesting a private symbol). The import belongs at the top of the file alongside the other standard library imports (pickle, yaml, marshal).

Fix in Cursor Fix in Web


return f"Session restored: {session}"

Expand Down
Loading