Fix Rails 7.1 fixture_path deprecation warning#499
Open
MattRogish wants to merge 1 commit into
Open
Conversation
Use `fixture_paths=` (plural, array) on Rails 7.1+ and fall back to `fixture_path=` (singular) on older versions.
Contributor
Author
|
I guess maybe the right thing to do is bump |
Collaborator
|
I think upgrading rspec sounds like a good idea if you're willing to give it a go 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a clean checkout, when running
bundle exec specI got the following:I made
fixture_paths=/ fall back tofixture_path=.rspechas officially made this change upstream, so presumably this warning will persist and/or this functionality will break at some point in the future?