Respect the api version that is being set in the ConfigurationVO#12
Open
skoop wants to merge 2 commits intocolorfield:masterfrom
Open
Respect the api version that is being set in the ConfigurationVO#12skoop wants to merge 2 commits intocolorfield:masterfrom
skoop wants to merge 2 commits intocolorfield:masterfrom
Conversation
Author
|
Hi @colorfield! Any chance this could be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened?
I was creating a ConfigurationVO object and I was setting the
$apiVersionparameter tov2. When I then used theMastodonAPIobject that I can created using the ConfigurationVO object, when I called (in my case) the/searchendpoint, I got a 404 error from the API, because it was trying to call/api/v1/search. It did not respect thev2I had set because the code was using theConfigurationVO::API_VERSIONconstant, which is set tov1.The solution
Instead of using the constant from the ConfigurationVO class, I use the
$apiVersionproperty of the$this->configinstead of the VO. Now, when I call thegetPublicData('/search'), it respects the version and calls thev2API.