feat(communication): add unique ip in subnetwork check#455
Open
lorenzhoerburgerbearingpointcom wants to merge 3 commits into
Open
feat(communication): add unique ip in subnetwork check#455lorenzhoerburgerbearingpointcom wants to merge 3 commits into
lorenzhoerburgerbearingpointcom wants to merge 3 commits into
Conversation
noraeb
previously approved these changes
Mar 20, 2026
Author
|
Thanks @noraeb . Can i then go ahead and merge it? |
danyill
reviewed
Mar 23, 2026
danyill
left a comment
danyill
left a comment
There was a problem hiding this comment.
Just randomly, I provide a few comments for consideration 😉
Author
|
Hi @danyill , I implemented you feedback - thanks again :). Would you mind reviewing them? 🙂 |
Member
|
I suggest a bit more meaningful error message (if I'm correct): "Ip adres is already in use in the subnetwork, unique IP adres is required". |
Author
|
Thanks for the suggestion Sander! I agree, this message is much more meaningful. I'll update it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Communication Plugin Unique IP
The input is checked against existing IPs within the selected subnetwork, and a message is shown below the field if the IP is already assigned and unavailable.