Skip to content

feat(communication): add unique ip in subnetwork check #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenzhoerburgerbearingpointcom wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(communication): add unique ip in subnetwork check #455

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af8f926
feat(communication): add unique ip in subnetwork check
lorenzhoerburgerbearingpointcom Mar 20, 2026
4a66476
refactor(communication): use textContext and :scope-qualified selectors
lorenzhoerburgerbearingpointcom Mar 23, 2026
4d23c18
refactor(communication): derive SubNetwork via parentElement
lorenzhoerburgerbearingpointcom Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions packages/plugins/src/wizards/connectedap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,18 +329,36 @@ export function createTypeRestrictionCheckbox(
</mwc-formfield>`;
}

function getIpsInSubnetwork(element: Element): string[] {
const subnetwork = element.parentElement; // SubNetwork is the parent of ConnectedAP
if (!subnetwork) return [];

return Array.from(subnetwork.querySelectorAll(':scope > ConnectedAP > Address > P[type="IP"]'))
.map(p => p.textContent?.trim() ?? '')
.filter(ip => ip !== '');
}

export function createPTextField(
element: Element,
pType: string
): TemplateResult {
const currentValue =
element.querySelector(`:scope > Address > P[type="${pType}"]`)?.textContent?.trim() ??
null;

let reservedIPs: string[] = [];
if (pType === 'IP') {
reservedIPs = getIpsInSubnetwork(element).filter(ip => ip !== currentValue);
}

return oscdHtml`<wizard-textfield
required
label="${pType}"
pattern="${ifDefined(typePattern[pType])}"
?nullable=${typeNullable[pType]}
.maybeValue=${element.querySelector(`:scope > Address > P[type="${pType}"]`)
?.innerHTML ?? null}
.maybeValue=${currentValue}
maxLength="${ifDefined(typeMaxLength[pType])}"
.reservedValues=${reservedIPs}
></wizard-textfield>`;
}

Expand Down
Loading